Skip to content

listenHTTP: fixes after #199 - #203

Merged
filippi merged 1 commit into
forefireAPI:masterfrom
antonio-leblanc:fix/listenhttp-after-199
Oct 21, 2026
Merged

filippi merged 1 commit into
forefireAPI:masterfrom
antonio-leblanc:fix/listenhttp-after-199

Conversation

@antonio-leblanc

Copy link
Copy Markdown
Collaborator

Follow-up to #199: Docker docs use listenHTTP[0.0.0.0:8000], httpConnectInfo.txt gets the real hostname again on 0.0.0.0, [:port] means localhost, socket closed on bind failure, state restored on exceptions, and commands from another site or host name are refused. CHANGELOG links #199.

Thanks @HugoFara for the review.

Bind inside Docker with listenHTTP[0.0.0.0:8000] in the docs, treat an
empty host as localhost, write the real hostname to httpConnectInfo.txt
on 0.0.0.0, close the socket when bind fails, restore remoteCommand and
cout on exceptions, and refuse commands from another site or host name.

Thanks @HugoFara for the review.

@filippi filippi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better protection indeed

@filippi
filippi merged commit adfc35f into forefireAPI:master Oct 21, 2026
8 checks passed
antonio-leblanc added a commit that referenced this pull request Oct 21, 2026
# Conflicts:
#	CHANGELOG.md
#	src/Command.cpp
#	src/Command.h
antonio-leblanc added a commit that referenced this pull request Oct 21, 2026
filippi added a commit that referenced this pull request Oct 22, 2026
* docs(changelog): correct the v2.5.0 wheel platforms

PyPI has three wheels for 2.5.0 -- manylinux x86_64, manylinux aarch64 and
macosx_14_0_arm64. There is no Intel macOS wheel: the macos-13 runner was
retired and its job dropped in e43e0a0, which is an ancestor of the tag.

* docs(changelog): add the entries merged since v2.5.0 without one

#179, #181, #182, #189, #190, #192 and #197 had no entry, and the
listenHTTP entry did not credit #203. Version bumps, merges and the
documentation backports are left out.

---------

Co-authored-by: Jean-Baptiste Filippi <batti.filippi@gmail.com>
@antonio-leblanc
antonio-leblanc deleted the fix/listenhttp-after-199 branch October 23, 2026 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants