Repository navigation
Fix AutoDoc runs with GAPDoc or the scaffold disabled - #392
Merged
Merged
Conversation
The scaffold took the book name and main XML file name from the GAPDoc settings, which are unbound when GAPDoc is disabled. So AutoDoc with gapdoc := false and a scaffold failed, as did AutoDocWorksheet with gapdoc := false. Determine both names regardless of whether GAPDoc runs. AutoDocWorksheet also failed with scaffold := false or true, as it treated the value as a record. Assisted-by: Generative AI
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #392 +/- ##
==========================================
+ Coverage 93.08% 93.52% +0.44%
==========================================
Files 15 15
Lines 3180 3196 +16
==========================================
+ Hits 2960 2989 +29
+ Misses 220 207 -13
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scaffold took the book name and main XML file name from the GAPDoc settings, which are unbound when GAPDoc is disabled. So AutoDoc with
gapdoc := falseand a scaffold failed, as didAutoDocWorksheetwithgapdoc := false. Determine both names regardless of whether GAPDoc runs.AutoDocWorksheetalso failed withscaffold := falseortrue, as it treated the value as a record.Assisted-by: Generative AI