Skip to content

Fix AutoDoc runs with GAPDoc or the scaffold disabled - #392

Merged
fingolfin merged 1 commit into
masterfrom
mh-ai/disabled-steps
Nov 15, 2026
Merged

fingolfin merged 1 commit into
masterfrom
mh-ai/disabled-steps

Conversation

@fingolfin

@fingolfin fingolfin commented Nov 15, 2026 •

Copy link
Copy Markdown
Member

The scaffold took the book name and main XML file name from the GAPDoc settings, which are unbound when GAPDoc is disabled. So AutoDoc with gapdoc := false and a scaffold failed, as did AutoDocWorksheet with gapdoc := false. Determine both names regardless of whether GAPDoc runs.

AutoDocWorksheet also failed with scaffold := false or true, as it treated the value as a record.

Assisted-by: Generative AI

The scaffold took the book name and main XML file name from the
GAPDoc settings, which are unbound when GAPDoc is disabled. So
AutoDoc with gapdoc := false and a scaffold failed, as did
AutoDocWorksheet with gapdoc := false. Determine both names
regardless of whether GAPDoc runs.

AutoDocWorksheet also failed with scaffold := false or true, as it
treated the value as a record.

Assisted-by: Generative AI
@codecov

codecov Bot commented Nov 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.10345% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.52%. Comparing base (bd44b5e) to head (4fdce5e).

Files with missing lines Patch % Lines
gap/Magic.gi 91.30% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #392      +/-   ##
==========================================
+ Coverage   93.08%   93.52%   +0.44%     
==========================================
  Files          15       15              
  Lines        3180     3196      +16     
==========================================
+ Hits         2960     2989      +29     
+ Misses        220      207      -13     
Files with missing lines Coverage Δ
gap/AutoDocMainFunction.gi 94.02% <100.00%> (+0.43%) ⬆️
gap/Magic.gi 78.65% <91.30%> (+3.35%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fingolfin
fingolfin enabled auto-merge (squash) November 15, 2026 17:01
@fingolfin
fingolfin merged commit 1a2b3ec into master Nov 15, 2026
5 checks passed
@fingolfin
fingolfin deleted the mh-ai/disabled-steps branch November 15, 2026 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant