Skip to content

chore: sync upstream (2026-11-17) - #29

Merged
getBoolean merged 187 commits into
mainfrom
sync/upstream-2026-11-17
Nov 17, 2026
Merged

getBoolean merged 187 commits into
mainfrom
sync/upstream-2026-11-17

Conversation

@getBoolean

@getBoolean getBoolean commented Nov 17, 2026 •

Copy link
Copy Markdown
Owner

Merges upstream pingdotgg/t3code main into the fork: 629d5083b7..9830b857de (185 commits). The largest changes are issue tracking across web, mobile and agent tools (GitHub, GitLab, Azure DevOps, Forgejo, Linear), saved filter views, an optional terminal close confirmation, a configurable interactive shell, and sparse-checkout worktrees.

Conflicts and resolutions

  • apps/server/src/auth/RpcAuthorization.test.ts: kept the fork's gitAccounts providers-manage assertion and upstream's new simlockDeviceHosts assertion.
  • apps/server/src/serverSettings.test.ts: union of imports (GitAccountId, SourceControlProviderKind, SimlockDeviceHostConfig).
  • apps/server/src/project/ProjectSetupScriptRunner.test.ts: upstream added an opens array with the same role as the fork's opened. Merged them into the fork's opened (typed TerminalManagerOpenInput), so upstream's shell-preference test and the fork's git-account test both read it.
  • apps/server/src/provider/agentContextBudget.json: re-measured as 52922 (upstream's 52145 plus the fork's usual 777-byte git-account tool delta).
  • packages/source-control-gitlab/src/server/GitLabCli.test.ts: kept the fork marker, the Redacted import, and upstream's NodeServices and Path imports.
  • docs/user/project-settings.md: upstream's "Source control & issues" wording, plus the fork's git-account sentence.
  • apps/mobile/src/lib/pullRequestNavigation.ts: kept the fork's iosPullRequestNavigationAction and upstream's pullRequestCandidateForIssueLink.
  • apps/mobile/src/native/useOpenPullRequest.ts: union of imports. Upstream's new issue-link → pull-request path now uses the fork's iPad detail-reuse action too.
  • apps/mobile/src/features/threads/ThreadFeed.tsx: fork marker plus upstream's imports.
  • apps/mobile/src/features/settings/SettingsServerControlsRouteScreen.tsx: upstream moved forge sign-in into SourceControlProvidersSection and added IssueTrackerSection. Kept the fork's GitAccountsSection and dropped the now-unused SourceControlSignInSection import.
  • WorkspaceTabsContext.tsx, createWorkspaceStackNavigator.ios.tsx, WorkspaceNativeTabs.ios.tsx: union of imports. The sidebar footer uses upstream's useWorkspaceCompose while keeping the fork's iPad sidebar-navigation branch.

Fork adaptations

  • iPad Issues tab. On iPad the fork drives navigation from sidebar destinations, so upstream's new mobile Issues tab was unreachable there: workspaceSidebarDestination ignored issue routes, and opening issues with sidebar navigation landed on Usage. Added an Issues workspace list route (IssueListRouteScreen, sharing the pull request list's wrapper), an Issues row in IpadSidebarActions, and issue-route detection in workspace-tab-navigation. Extended workspace-tab-navigation.test.ts and recorded everything in .github/fork-manifest.txt.
  • Fork CI audit (--rewrite-runners --prefix T3CODE): no new runner labels or repository guards needing changes. The new EAS workflows already use T3CODE_* runners. ci.yml gains only Linux steps (Linear GraphQL and i18n checks), so there are no new macOS jobs to gate. The only new hard-coded pingdotgg/t3code is in a server test.
  • No upstream bump of a patched dependency. All patches applied on install.

Verification

  • bash scripts/check-fork-manifest.sh: 561 entries present.
  • Server fork suites plus conflicted tests (gitAccounts, terminal Manager, npmRelease, PullRequestService, mcp project toolkit, AgentContextBudget, RpcAuthorization, ProjectSetupScriptRunner, serverSettings): 436 passed.
  • GitLabCli: 13 passed. Mobile layout, lib, native and settings suites plus remoteRegistration: 1102 passed. Web GitAccountsSettings browser test: 2 passed.
  • vp run check:changed: format, lint, knip, graphql, unused patches and typecheck (42 packages) pass. Its local test and React compiler steps timed out on this heavily loaded Mac; CI runs both suites in full.
  • CI: every check passes except Git Account Tests / Test (macos-latest), which hosted macOS capacity cancelled four times ("not acquired by Runner"). I ran that job's exact steps on this Mac (macOS) instead, and all passed: server account suites 552, driver env passthrough 1, source-control packages 1,124 (github 401, gitlab 273, forgejo 70, bitbucket 93, azure-devops 176, gitcafe 111), shared settings 24. Its Linux leg passes in CI.

iOS 17

Passed. deploymentTarget stays 17.0.

  • Risk read: no native dependency added or bumped (no mobile package.json or podspec-minimum changes). New Swift in T3ScrollEdgeBleedView uses registerForTraitChanges behind #available(iOS 27.1, *). T3SidebarTabBarView and the podspec only add the Issues tab and its icon assets. The Issues icon is a bundled Tabler glyph, not an SF Symbol. infra/relay and packages/contracts/src/relay.ts are unchanged.
  • Build: Release simulator build with Xcode 26.6, React Native built from source: succeeded. Deployment targets are 16.4 and 17.0.
  • Symbols: libc++ check: 277 symbols, all exported by iOS 17.0. check_runtime_symbols.py --runtime 17.0: 10,979 imports from 7 Mach-O files, nothing missing.
  • Launch: iPhone 15 Pro and iPad Pro 12.9" (6th gen) on iOS 17.0 (21A328) both kept running past 30 seconds. As in the last sync, the app was installed with simctl because agent-device's tar install drops the sparse hermesvm binary (dyld "Library missing"). That's a tool issue, not an app issue. On the iPad, the new sidebar Issues row opens the Issues list beside the thread sidebar.
  • Native walk (native-surfaces-open, against its own throwaway server): iPad passed with 0 failed steps. The iPhone's first run failed one step: it could not tap the "Tokens" segment on Usage, though the segment was on screen. A rerun passed all 42 steps with no crash, uncaught error or rejection, and the iPad passed the same step, so this was a tap flake.
Release launch, iPhone 15 Pro (iOS 17.0) Release launch, iPad Pro 12.9" (iOS 17.0) iPad sidebar → Issues
Walk iPhone 15 Pro iPad Pro 12.9"
Compose
Source control (git accounts)
Usage
Thread

Model: Claude Opus 5.5 (claude-opus-5-5), harness: Claude Code in T3 Code.

arifali123 and others added 30 commits November 16, 2026 04:13
pingdotgg#37605)

Co-authored-by: Orin <orin@orin.ws>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…oaded" (pingdotgg#37651)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
…otgg#37632)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
…he id (pingdotgg#37493)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
…otgg#37150)

Co-authored-by: Simone <185146821+Lucenx9@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
… keep uploading (pingdotgg#37681)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
)

Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Marker-bit <Marker-bit@users.noreply.github.com>
…gdotgg#37703)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: screen <screen@users.noreply.git.cafe>
Co-authored-by: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ead (pingdotgg#37735)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ingdotgg#37741)

Co-authored-by: Usama Khan <usama@Usamas-MacBook-Pro.local>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com>
StiensWout and others added 22 commits November 17, 2026 01:11
…dotgg#38017)

Co-authored-by: Grok 4.7 <noreply@x.ai>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…gg#38021)

Co-authored-by: Grok 4.7 <noreply@x.ai>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…dy (pingdotgg#38025)

Co-authored-by: Grok 4.7 <noreply@x.ai>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ore fails (pingdotgg#38035)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
…art (pingdotgg#38043)

Co-authored-by: Grok 4.7 <noreply@x.ai>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…it saves (pingdotgg#38031)

Co-authored-by: Grok 4.7 <noreply@x.ai>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ad spans (pingdotgg#38083)

Co-authored-by: Martin Bergo <14320143+mInrOz@users.noreply.github.com>
)

Co-authored-by: Cursor <cursoragent@cursor.com>
# Conflicts:
#	apps/mobile/src/features/layout/createWorkspaceStackNavigator.ios.tsx
#	apps/mobile/src/features/layout/workspace/WorkspaceNativeTabs.ios.tsx
#	apps/mobile/src/features/layout/workspace/WorkspaceTabsContext.tsx
#	apps/mobile/src/features/settings/SettingsServerControlsRouteScreen.tsx
#	apps/mobile/src/features/threads/ThreadFeed.tsx
#	apps/mobile/src/lib/pullRequestNavigation.ts
#	apps/mobile/src/native/useOpenPullRequest.ts
#	apps/server/src/auth/RpcAuthorization.test.ts
#	apps/server/src/project/ProjectSetupScriptRunner.test.ts
#	apps/server/src/provider/agentContextBudget.json
#	apps/server/src/serverSettings.test.ts
#	docs/user/project-settings.md
#	packages/source-control-gitlab/src/server/GitLabCli.test.ts
@getBoolean getBoolean added the agent-context-increase Accepts growth in the agent context budget label Nov 17, 2026
@github-actions github-actions Bot added vouch:trusted Author is trusted by repo permissions or the VOUCHED list. size:XXL labels Nov 17, 2026
@github-actions

Copy link
Copy Markdown

This PR changes the test suite by +265 test cases (browser +30, unit +155, server +80).

New browser test files: apps/web/src/components/SavedViewsMenu.browser.test.tsx, apps/web/src/components/pullRequest/PullRequestReactions.browser.test.tsx, apps/web/src/speech/browserVoiceInput.browser.test.ts.
Each browser test file costs CI seconds of module loading before its first test runs; a unit test costs milliseconds.

Keep tests that would fail for a real reason, and test logic below the UI where it can be. See Testing.

@github-actions github-actions Bot added the 📱 Native Change Changes the native fingerprint; merging blocks production OTAs until a new store build ships. label Nov 17, 2026
@github-actions

Copy link
Copy Markdown

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ The exact PR base did not have a successful artifact. Baseline uses the latest successful main measurement shown below.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 5.0 KiB 5.0 KiB 0 B (0.0%) 6.8 KiB ✅
Codex Thread snapshot wire 3.8 KiB 3.8 KiB 0 B (0.0%) 4.9 KiB ✅
Codex Live turn WebSocket wire 1.2 KiB 1.2 KiB 0 B (0.0%) 2.0 KiB ✅
Codex Live turn WebSocket decoded 21.5 KiB 21.5 KiB 0 B (0.0%) 24.4 KiB ✅
Codex Live turn messages 1 1 0 (0.0%) 8 ✅
Claude Total thread wire 5.0 KiB 5.0 KiB 0 B (0.0%) 6.8 KiB ✅
Claude Thread snapshot wire 3.8 KiB 3.8 KiB 0 B (0.0%) 4.9 KiB ✅
Claude Live turn WebSocket wire 1.2 KiB 1.2 KiB 0 B (0.0%) 2.0 KiB ✅
Claude Live turn WebSocket decoded 21.9 KiB 21.9 KiB 0 B (0.0%) 24.4 KiB ✅
Claude Live turn messages 1 1 0 (0.0%) 8 ✅

Other scenarios

All 64 scenario measurements match main.

All 64 scenario measurements
Provider Scenario Metric Main baseline This PR Impact PR ceiling
Codex short turn resume WebSocket decoded 10.5 KiB 10.5 KiB 0 B (0.0%) 12.7 KiB ✅
Codex short turn resume WebSocket messages 2 2 0 (0.0%) 2 ✅
Codex long turn running, cold open HTTP decoded 230.3 KiB 230.3 KiB 0 B (0.0%) 302.7 KiB ✅
Codex long turn running, cold open rows 25 25 0 (0.0%) 75 ✅
Codex long turn running, history page HTTP decoded 89.3 KiB 89.3 KiB 0 B (0.0%) 107.4 KiB ✅
Codex long turn running, history page rows 75 75 0 (0.0%) 75 ✅
Codex long turn finished, cold open HTTP decoded 68.3 KiB 68.3 KiB 0 B (0.0%) 410.2 KiB ✅
Codex long turn finished, cold open rows 21 21 0 (0.0%) 151 ✅
Codex long turn finished, socket cold open WebSocket decoded 68.4 KiB 68.4 KiB 0 B (0.0%) 410.2 KiB ✅
Codex long turn finished, socket cold open WebSocket messages 2 2 0 (0.0%) 2 ✅
Codex long turn finished, socket cold open rows 21 21 0 (0.0%) 151 ✅
Codex long turn finished, work page HTTP decoded 94.4 KiB 94.4 KiB 0 B (0.0%) 200.2 KiB ✅
Codex long turn finished, work page rows 75 75 0 (0.0%) 150 ✅
Codex idle thread resume WebSocket decoded 65 B 65 B 0 B (0.0%) 200 B ✅
Codex idle thread resume WebSocket messages 1 1 0 (0.0%) 1 ✅
Codex fleet shell snapshot HTTP decoded 42.4 KiB 42.4 KiB 0 B (0.0%) 53.7 KiB ✅
Codex fleet shell snapshot rows 27 27 0 (0.0%) 27 ✅
Codex fleet shell subscribe WebSocket decoded 65 B 65 B 0 B (0.0%) 200 B ✅
Codex fleet shell subscribe WebSocket messages 1 1 0 (0.0%) 1 ✅
Codex fleet shell resume check HTTP decoded 18 B 18 B 0 B (0.0%) 100 B ✅
Codex fleet shell resume check rows 0 0 0 0 ✅
Codex stale shell reload HTTP decoded 42.4 KiB 42.4 KiB 0 B (0.0%) 53.7 KiB ✅
Codex stale shell reload rows 27 27 0 (0.0%) 27 ✅
Codex stale shell resume WebSocket decoded 140 B 140 B 0 B (0.0%) 400 B ✅
Codex stale shell resume WebSocket messages 2 2 0 (0.0%) 2 ✅
Codex stale todo list cold open HTTP decoded 36.4 KiB 36.4 KiB 0 B (0.0%) 83.0 KiB ✅
Codex stale todo list cold open rows 25 25 0 (0.0%) 75 ✅
Codex stale todo list cold open nodes 2 2 0 (0.0%) 4 ✅
Codex stale todo list cold open subagents 2 2 0 (0.0%) 4 ✅
Codex stale todo list cold open plans 1 1 0 (0.0%) 2 ✅
Codex stale todo list cold open providerTurns 1 1 0 (0.0%) 2 ✅
Codex stale todo list cold open checkpoints 1 1 0 (0.0%) 2 ✅
Claude short turn resume WebSocket decoded 10.6 KiB 10.6 KiB 0 B (0.0%) 12.7 KiB ✅
Claude short turn resume WebSocket messages 2 2 0 (0.0%) 2 ✅
Claude long turn running, cold open HTTP decoded 231.3 KiB 231.3 KiB 0 B (0.0%) 302.7 KiB ✅
Claude long turn running, cold open rows 25 25 0 (0.0%) 75 ✅
Claude long turn running, history page HTTP decoded 90.2 KiB 90.2 KiB 0 B (0.0%) 107.4 KiB ✅
Claude long turn running, history page rows 75 75 0 (0.0%) 75 ✅
Claude long turn finished, cold open HTTP decoded 68.7 KiB 68.7 KiB 0 B (0.0%) 410.2 KiB ✅
Claude long turn finished, cold open rows 21 21 0 (0.0%) 151 ✅
Claude long turn finished, socket cold open WebSocket decoded 68.8 KiB 68.8 KiB 0 B (0.0%) 410.2 KiB ✅
Claude long turn finished, socket cold open WebSocket messages 2 2 0 (0.0%) 2 ✅
Claude long turn finished, socket cold open rows 21 21 0 (0.0%) 151 ✅
Claude long turn finished, work page HTTP decoded 95.4 KiB 95.4 KiB 0 B (0.0%) 200.2 KiB ✅
Claude long turn finished, work page rows 75 75 0 (0.0%) 150 ✅
Claude idle thread resume WebSocket decoded 66 B 66 B 0 B (0.0%) 200 B ✅
Claude idle thread resume WebSocket messages 1 1 0 (0.0%) 1 ✅
Claude fleet shell snapshot HTTP decoded 43.0 KiB 43.0 KiB 0 B (0.0%) 53.7 KiB ✅
Claude fleet shell snapshot rows 27 27 0 (0.0%) 27 ✅
Claude fleet shell subscribe WebSocket decoded 66 B 66 B 0 B (0.0%) 200 B ✅
Claude fleet shell subscribe WebSocket messages 1 1 0 (0.0%) 1 ✅
Claude fleet shell resume check HTTP decoded 18 B 18 B 0 B (0.0%) 100 B ✅
Claude fleet shell resume check rows 0 0 0 0 ✅
Claude stale shell reload HTTP decoded 43.0 KiB 43.0 KiB 0 B (0.0%) 53.7 KiB ✅
Claude stale shell reload rows 27 27 0 (0.0%) 27 ✅
Claude stale shell resume WebSocket decoded 140 B 140 B 0 B (0.0%) 400 B ✅
Claude stale shell resume WebSocket messages 2 2 0 (0.0%) 2 ✅
Claude stale todo list cold open HTTP decoded 36.8 KiB 36.8 KiB 0 B (0.0%) 83.0 KiB ✅
Claude stale todo list cold open rows 25 25 0 (0.0%) 75 ✅
Claude stale todo list cold open nodes 2 2 0 (0.0%) 4 ✅
Claude stale todo list cold open subagents 2 2 0 (0.0%) 4 ✅
Claude stale todo list cold open plans 1 1 0 (0.0%) 2 ✅
Claude stale todo list cold open providerTurns 1 1 0 (0.0%) 2 ✅
Claude stale todo list cold open checkpoints 1 1 0 (0.0%) 2 ✅

Baseline: 1b044d6 · PR result: d9bd9af · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 108.5 KiB
  • Claude decoded thread snapshot: 108.8 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@getBoolean
getBoolean merged commit 8180bca into main Nov 17, 2026
56 of 60 checks passed
@getBoolean
getBoolean deleted the sync/upstream-2026-11-17 branch November 17, 2026 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-context-increase Accepts growth in the agent context budget 📱 Native Change Changes the native fingerprint; merging blocks production OTAs until a new store build ships. size:XXL vouch:trusted Author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.