Skip to content

feat(dropped data): Dropped data is only filtered by project and time - #20243

Merged
sfanahata merged 1 commit into
masterfrom
sanahata/feat/dropped-data-filters
Oct 27, 2026
Merged

sfanahata merged 1 commit into
masterfrom
sanahata/feat/dropped-data-filters

Conversation

@sfanahata

Copy link
Copy Markdown
Contributor

DESCRIBE YOUR PR

Updating doc to reflect that dropped data is only filtered by project and time.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.
Select exactly one option. For deadlines, replace YYYY-MM-DD with the due date. You can update this information later by editing the PR description.

  • Urgent deadline (GA date, etc.): 2026-10-28
  • Other deadline: YYYY-MM-DD
  • No deadline: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've supplied a deadline.

Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

Co-authored-by: Cursor <cursoragent@cursor.com>
@vercel

vercel Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
sentry-docs Ready Ready Preview Oct 26, 2026 11:38pm UTC
1 Skipped Deployment
Project Deployment Actions Updated
develop-docs Ignored Ignored Oct 26, 2026 11:38pm UTC

Request Review

@sfanahata
sfanahata requested a review from bcoe October 26, 2026 23:33
@github-actions github-actions Bot added the Priority: Urgent Docs review is needed immediately for an urgent deadline label Oct 26, 2026
@codeowner-assignment
codeowner-assignment Bot requested a review from a team October 26, 2026 23:33
@cursor

cursor Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

The change adds a note that dropped data views filter only by time and project. The plan checks page-load volume, failed requests, and error events on that page. An issue escalates when errors rise or the page stops loading.

Monitoring in production

Services: sentry-docs.

Mention @change-monitor in a comment to update the plan.

Plan

What changed

Readers of the dropped data page now see a note. The note says charts and the details list filter only by time and project.
This ships when sentry-docs deploys to production on Vercel. The file lives under docs/, so develop-docs does not ship it.

Risk

Bad MDX can fail the static build and block the whole site ship.
If the page still ships, a render fault would fail or crash that page only.
Wrong wording does not page. Readers could trust extra filters that the product does not apply.

Intended effect

This is a docs text change. No metric increments when the note appears.
Confirmed means the live page contains this sentence: The dropped data you see on your chart, and in the details list, is only filtered by time and project.
Absent means that sentence is missing after the production ship.
Do not treat a quiet error stream as confirmation.

Regression watch

This diff can break render of /product/explore/dropped-data/. Watch that path, not fleet health.
Traces on this path use a 30% sample. docs.page.load is not sampled. Prefer the load metric for volume.
Transaction name is /:path*. Filter errors by URL, not by transaction name.

Signal Baseline Window Rule Source
Error events with url containing dropped-data 1 event per 10 docs.page.load counts, rate 0-10%. The one event is recaptcha TypeError DOCS-BG5. 2026-10-25T23:34:13Z to 2026-10-26T23:34:13Z Hold 0-1 events per 24h at similar load volume. Escalate when a new error type appears, or when the rate rises above 10% at similar volume. Ignore recaptcha DOCS-BG5. Sentry org sentry, project docs. Query environment:production AND url:*dropped-data*. Dataset errors.
Spans with HTTP 500 or span.status:internal_error on this path 0 spans. Rate 0% of path traffic. 2026-10-25T23:34:13Z to 2026-10-26T23:34:13Z Hold at 0. Any 5xx or internal error on this path is a regression. Sentry org sentry, project docs. Query environment:production url.path:"/product/explore/dropped-data/" (http.status_code:500 OR span.status:internal_error). Dataset spans.
docs.page.load with path containing dropped-data 10 loads in the last 24h. 5 loads in the prior 24h. Band 5-10 loads per 24h. Last 24h 2026-10-25T23:34:13Z to 2026-10-26T23:34:13Z. Prior 24h 2026-10-24T23:34:13Z to 2026-10-25T23:34:13Z. Hold in 5-10 per 24h. Escalate when the path stays at 0 for a full 24h after the ship. Sentry org sentry, project docs. Query metric.name:docs.page.load AND sentry.environment:production AND path:*dropped-data*. Sum the counter.

Not observable

The new sentence has no telemetry. The live page text is the only intended-effect check.
docs.page.not_found with requested_path:product/explore returned no series. Do not treat that as zero.
Prior-day p95 on this path is not usable. Sampled pageload and navigation count was 7 in 24h and 10 in 48h.

Get Slack DMs about this change: cursor.com/automations/rollouts

@sfanahata
sfanahata merged commit 24488e5 into master Oct 27, 2026
26 checks passed
@sfanahata
sfanahata deleted the sanahata/feat/dropped-data-filters branch October 27, 2026 17:51
@cursor

cursor Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Verified in production

  • The live dropped-data page still shows the new note, and that path stayed healthy after the ship.

This branch was successfully deployed

1 active deployment
Preview – sentry-docs — 6339b002 Deployed Oct 26, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: Urgent Docs review is needed immediately for an urgent deadline

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants