Repository navigation
test(spring-boot): [Sample Tests 17] Move the Boot 3 WebFlux sample's tests into the module - #6308
Draft
runningcode wants to merge 7 commits into
Draft
runningcode wants to merge 7 commits into
runningcode wants to merge 7 commits into
Conversation
Draft
4 of 9 tasks
📲 Install BuildsAndroid
|
This was referenced Oct 20, 2026
Draft
Draft
Draft
Draft
5 of 9 tasks
runningcode
force-pushed
the
no/delete-log4j2-boot-system-tests
branch
from
October 21, 2026 09:19
d920038 to
ab05cf1
Compare
runningcode
force-pushed
the
no/boot3-webflux-integration-test
branch
2 times, most recently
from
October 21, 2026 11:27
6f7ce55 to
e5ffa4d
Compare
runningcode
force-pushed
the
no/delete-log4j2-boot-system-tests
branch
2 times, most recently
from
October 22, 2026 12:40
ca0c043 to
7473271
Compare
runningcode
force-pushed
the
no/boot3-webflux-integration-test
branch
from
October 22, 2026 12:40
e5ffa4d to
6c38c20
Compare
runningcode
force-pushed
the
no/delete-log4j2-boot-system-tests
branch
from
October 22, 2026 13:31
7473271 to
7b862db
Compare
runningcode
force-pushed
the
no/boot3-webflux-integration-test
branch
3 times, most recently
from
October 22, 2026 16:02
95a686c to
33f8060
Compare
runningcode
force-pushed
the
no/delete-log4j2-boot-system-tests
branch
2 times, most recently
from
October 23, 2026 08:24
0dd9a37 to
411f8e5
Compare
runningcode
force-pushed
the
no/boot3-webflux-integration-test
branch
2 times, most recently
from
October 23, 2026 08:58
3220952 to
7a36f8e
Compare
runningcode
force-pushed
the
no/delete-log4j2-boot-system-tests
branch
from
October 23, 2026 09:35
13cce21 to
7658695
Compare
runningcode
force-pushed
the
no/boot3-webflux-integration-test
branch
2 times, most recently
from
October 23, 2026 11:51
138c1d1 to
81c306e
Compare
…odule Ports the Boot 2 sample's GraphQL and Kafka tests to the integrationTest suite. Both need Spring Boot 2.7, while the Spring Boot 2 matrix also covers 2.4 to 2.6, so below 2.7 the suite leaves out their dependencies and sources. That also keeps the broker off the shared base class: the Kafka test runs its own application context under a kafka profile with @embeddedkafka, and each context gets its own in-memory database. The second context re-initializes the global SDK; the app reaches Sentry through ScopesAdapter, so the other tests pass in either order. The Boot 2 sample has no system tests left, so it comes off the system-test runner, the backend workflow and the Spring Boot 2 matrix. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
… creator ids Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The jakarta-log4j2 and 4-log4j2 samples' system tests were copies of the plain samples' tests, which now run in the modules' integrationTest suites. The only addition was a check that a logged error carries the Log4j integration. That's covered by SentryLog4j2AppenderAutoConfigurationTest, which checks the appender Spring Boot attaches, and by sentry-log4j2's own tests of what the appender sends. Both samples come off the system-test runner and the backend workflow. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The log4j2 Boot samples' tests were removed as covered elsewhere, but nothing else sends an event through the Log4j2 appender that Spring Boot's auto-configuration attaches. integrationTestLog4j2, in sentry-spring-boot-jakarta and sentry-spring-boot-4, runs a servlet app with Log4j2 instead of Logback and checks that an error logged through SLF4J reaches Sentry with the request's feature flag and the Log4j integration, as the samples' Person test did. Gradle's module replacement swaps the starters, as Spring Boot documents. It only acts on a classpath with both, which only this suite has. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…dule Adds an integrationTestWebflux suite to sentry-spring-boot-jakarta. It runs a reactive app without the servlet stack, so Spring Boot starts a WebFlux server, and ports the WebFlux sample's Person, DistributedTracing, Todo and GraphQL tests. The sample's Cache and Metrics tests were copies of the servlet ones and don't depend on the web stack, so the integrationTest suite already covers them. The WebFlux sample has no system tests left, so it comes off the system-test runner, the backend workflow and the Spring Boot 3 matrix, which now runs the new suite. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…ore Cache and Metrics Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…lver The sample's resolver returned a Mono, so its test covered Sentry finishing the field's span when the Mono completes. The port returned a String, which only covers the synchronous path. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
runningcode
force-pushed
the
no/delete-log4j2-boot-system-tests
branch
from
October 23, 2026 12:48
0d7fbb8 to
cac3297
Compare
runningcode
force-pushed
the
no/boot3-webflux-integration-test
branch
from
October 23, 2026 12:48
81c306e to
95a0f9f
Compare
runningcode
force-pushed
the
no/delete-log4j2-boot-system-tests
branch
from
October 23, 2026 13:02
cac3297 to
0e2c0b7
Compare
runningcode
force-pushed
the
no/boot3-webflux-integration-test
branch
from
October 23, 2026 13:02
95a0f9f to
1f31f97
Compare
runningcode
force-pushed
the
no/delete-log4j2-boot-system-tests
branch
from
October 23, 2026 13:28
0e2c0b7 to
0523822
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Stack (Sample Tests)
main)📜 Description
Adds an
integrationTestWebfluxsuite tosentry-spring-boot-jakarta. Its classpath has WebFlux but not the servlet stack, so Spring Boot starts a reactive Netty server. It ports these tests fromsentry-samples-spring-boot-webflux-jakarta:http.servertransaction, and logs.Mono, and is traced and profiled.WebClient.http.clientspan. It calls a local stub instead of the internet.The sample's
CacheSystemTestandMetricsSystemTestwere byte-identical to the servlet ones. They run in this suite too, with cache tracing enabled as the sample had it, so their assertions also hold in the reactive app.The app builds its own URLs from the incoming request, because a reactive app has no servlet request to read them from. The suite sets
sentry.reactive.thread-local-accessor-enabled=true, like the sample.With no system tests left, the sample comes off the runner, the backend workflow and the Spring Boot 3 matrix. The matrix now runs the new suite.
After a coverage audit against the sample's tests:
sample_randand deferred-sampling tests check the envelope header's trace ID, and a test client built outside the context, as in test(spring-boot): [Sample Tests 7] Move the Boot 3 tracing and HTTP client tests #6293.💡 Motivation and Context
This continues moving the sample system tests into modules, starting the WebFlux flavor with Boot 3.
💚 How did you test it?
:sentry-spring-boot-jakarta:checkpasses.📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
The Boot 4 and Boot 2 WebFlux samples.
#skip-changelog