Repository navigation
Conversation
logaretm
added this pull request to stack #25201
October 15, 2026 16:04
Contributor
size-limit report 📦
|
logaretm
force-pushed
the
awad/tunnel-astro
branch
2 times, most recently
from
October 15, 2026 16:38
3dfbedc to
e9cafef
Compare
logaretm
force-pushed
the
awad/tunnel-astro
branch
from
October 15, 2026 17:15
e9cafef to
aa89862
Compare
logaretm
force-pushed
the
awad/tunnel-astro
branch
from
October 15, 2026 17:36
aa89862 to
3b1e94f
Compare
logaretm
force-pushed
the
awad/tunnel-astro
branch
from
October 15, 2026 17:44
3b1e94f to
f8eea69
Compare
logaretm
force-pushed
the
awad/tunnel-astro
branch
from
October 15, 2026 18:16
f8eea69 to
bb2078f
Compare
logaretm
force-pushed
the
awad/tunnel-astro
branch
from
October 15, 2026 18:26
bb2078f to
9c5e4d6
Compare
logaretm
force-pushed
the
awad/tunnel-astro
branch
from
October 15, 2026 18:28
9c5e4d6 to
62ef54d
Compare
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
logaretm
force-pushed
the
awad/tunnel-astro
branch
from
October 16, 2026 01:51
62ef54d to
40a29bc
Compare
Member
Author
|
bugbot run |
logaretm
force-pushed
the
awad/tunnel-astro
branch
from
October 16, 2026 02:25
40a29bc to
fcb4724
Compare
logaretm
force-pushed
the
awad/tunnel-astro
branch
from
October 16, 2026 03:32
fcb4724 to
acf7baf
Compare
logaretm
force-pushed
the
awad/tunnel-astro
branch
2 times, most recently
from
October 16, 2026 14:00
3c79c4e to
cd1c651
Compare
logaretm
force-pushed
the
awad/tunnel-astro
branch
from
October 19, 2026 17:34
fda291a to
ccccc31
Compare
logaretm
force-pushed
the
awad/tunnel-astro
branch
from
October 19, 2026 18:15
ccccc31 to
28d348f
Compare
logaretm
force-pushed
the
awad/tunnel-astro
branch
from
October 19, 2026 18:22
28d348f to
f1d1f8e
Compare
logaretm
force-pushed
the
awad/tunnel-astro
branch
from
October 19, 2026 18:36
f1d1f8e to
740bba2
Compare
logaretm
force-pushed
the
awad/tunnel-astro
branch
from
October 19, 2026 19:12
740bba2 to
d05ec99
Compare
logaretm
marked this pull request as ready for review
October 19, 2026 19:36
logaretm
requested review from
chargome and
s1gr1d
and removed request for
a team
October 19, 2026 19:37
The Sentry middleware runs first and answers tunnel requests. The integration hands Astro's `base` and `trailingSlash: 'always'` to both SDKs, so `tunnel: true` follows Astro's routing without repeating them.
…orks on a cold server
This reverts commit 6647a68. The middleware module ran the inline default init a second time, and running the init before a cold non-page request is a gap develop has for every server request, not one the tunnel adds.
The server's tunnel base path only reached `@sentry/astro`'s own server init. On Workers the client comes from `@sentry/cloudflare`, so the browser posted under `base` and got a 404. The server side of the tunnel options module now goes through core's managed tunnel defaults, and the Worker entry imports it first.
…the tunnel variant, and drop tests that repeat core's
logaretm
requested review from
JPeer264 and
isaacs
and removed request for
a team
October 19, 2026 20:08
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit ba30e6a. Configure here.
| span => | ||
| getSpanOp(span) === 'http.server' && | ||
| /\/docs\/[a-z0-9]{1,7}\/?$/.test( | ||
| String(span.attributes['url.path']?.value ?? span.attributes['url.full']?.value ?? span.name), |
There was a problem hiding this comment.
Test uses hardcoded span attributes
Low Severity
This was flagged because the PR review rules require test assertions on span ops and attributes to use @sentry/conventions constants. The new tunnel E2E test compares getSpanOp to 'http.server' and reads 'url.path' / 'url.full' as string literals instead of HTTP_SERVER, URL_PATH, and URL_FULL.
Additional Locations (1)
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit ba30e6a. Configure here.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the tunnel wiring to the astro SDK. We already had a global middleware active, so it works by adding logic to check if the incoming request is a tunnel request and if it is, then it will be handled.
This also respects the decision made earlier to follow the base path configured by the user.
closes #25463