Repository navigation
Conversation
Node's `init()` registers the diagnostics-channel injection hooks, but Deno's did not. A Deno user had to run with `--preload=npm:@sentry/deno/import`, and got no warning without it. The channel integrations still reported that they were installed, but recorded no spans. `DenoClient` now registers the hooks in its constructor, as `NodeClient` does, behind the same `enableRuntimeChannelInjection` option. `init()` then calls `detectOrchestrionSetup()`, which warns under `debug: true` when no injection is active. The hooks only apply to modules imported after `init()`. `@sentry/deno/import` still covers modules imported before it, such as static imports in the entry module. The injection package could not load on Deno without env permission. Its vendored `debug` package, and the `supports-color` that `debug` loads, read `process.env` at import time, and Deno throws on that read. The build now replaces `debug` with a small shim that logs through the Sentry logger. Because of this, tracing-hooks messages on Node now appear under `debug: true` and no longer under `DEBUG=@apm-js-collab/*`. The build also wraps the `process.env.TRACING_DUMP` read in tracing-hooks in a try/catch, so a transformed module does not count as failed when the read throws. Fixes #23892 Fixes JS-3518 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
isaacs
requested review from
JPeer264 and
mydea
and removed request for
a team
October 20, 2026 04:18
Contributor
size-limit report 📦
|
Member
Author
|
Bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 2764700. Configure here.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node's
init()registers the diagnostics-channel injection hooks, but Deno's did not. A Deno user had to run with--preload=npm:@sentry/deno/import, and got no warning without it. The channel integrations still reported that they were installed, but recorded no spans.DenoClientnow registers the hooks in its constructor, asNodeClientdoes, behind the sameenableRuntimeChannelInjectionoption.init()then callsdetectOrchestrionSetup(), which warns underdebug: truewhen no injection is active. The hooks only apply to modules imported afterinit().@sentry/deno/importstill covers modules imported before it, such as static imports in the entry module.The injection package could not load on Deno without env permission. Its vendored
debugpackage, and thesupports-colorthatdebugloads, readprocess.envat import time, and Deno throws on that read. The build now replacesdebugwith a small shim that logs through the Sentry logger. Because of this, tracing-hooks messages on Node now appear underdebug: trueand no longer underDEBUG=@apm-js-collab/*. The build also wraps theprocess.env.TRACING_DUMPread in tracing-hooks in a try/catch, so a transformed module does not count as failed when the read throws.Fixes #23892
Fixes JS-3518