Repository navigation
ref(tracing): Remove unused base64_stripped regex - #8148
Merged
Merged
Conversation
sentrivana
approved these changes
Oct 29, 2026
Contributor
Coverage Results 📊✅ 136856 passed | ⏭️ 7456 skipped | Total: 144312 | Pass Rate: 94.83% | Execution Time: 464m 37s 📊 Comparison with Base Branch
✨ Test counts unchanged from base. All tests are passing successfully. ✅ Patch coverage is 100.00% (no changed executable lines found; target 80%). Files with missing lines (1)
Coverage diff@@ Coverage Diff @@
## master #8148 +/-##
==========================================
+ Coverage 90.30% 90.32% +0.02%
==========================================
Files 203 203 —
Tracked lines 26874 26873 -1
Branches 10044 10044 —
==========================================
+ Hits 24268 24273 +5
+ Misses 2606 2600 -6
- Partials 1519 1520 +1Generated by Coverage Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the module-level
base64_strippedregex string fromsentry_sdk/tracing_utils.py. Nothing has used it since 2023.#1179 (Sep 2021) added it to validate the base64-encoded Sentry entry in the
tracestateheader. #1907 (Feb 2023, "Remove deprecatedtracestate") deleted its only use,re.search("^{b64}$".format(b64=base64_stripped), sentry_value), but left the definition and its comment behind.Evidence
git grep -n base64_strippedacross the whole repo matches only the definition.git log -S base64_strippedshows exactly two commits: the one that added it (feat(tracing): Addtracestateheader handling #1179) and the one that removed its only caller (Remove deprecatedtracestate#1907).base64_stripped.Why it's safe
sentry_sdkand doesn't appear indocs/,CHANGELOG.mdorMIGRATION_GUIDE.md.reis still used bySENTRY_TRACE_REGEXand other code in the module.Checks
uv run ruff checkandruff format --checkon the file pass.uv run --group typing mypy sentry_sdkpasses with no issues.TESTPATH=tests/tracing uv run tox -e py3.14-common: 426 passed.Issues
None. Found by a dead-code sweep.
via automation
sched_65eed06cc199036c2b13411096f412d4· Run IDsched_65eed06cc199036c2b13411096f412d4:1793269189822.--
View Junior Session [Sentry]