Skip to content

ref: Remove helpers left over from EventScrubber removal - #8158

Merged
sentrivana merged 1 commit into
major/3.0from
ivana/remove-event-scrubber-leftovers
Oct 29, 2026
Merged

sentrivana merged 1 commit into
major/3.0from
ivana/remove-event-scrubber-leftovers

Conversation

@sentry-junior

@sentry-junior sentry-junior Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Description

Removes two helpers that only EventScrubber used:

  • iter_event_frames() in sentry_sdk/utils.py
  • AnnotatedValue.substituted_because_contains_sensitive_data() in sentry_sdk/_types.py

#7772 ("Remove EventScrubber and the event_scrubber option") deleted sentry_sdk/scrubber.py, which held the only call to each of them: frame-vars scrubbing called iter_event_frames(event), and denylisted keys were replaced with AnnotatedValue.substituted_because_contains_sensitive_data(). Both helpers were left behind.

Evidence

  • On major/3.0, git grep -w for each name matches only its definition. There are no callers in sentry_sdk, tests, scripts or docs.
  • No open PR touches either one.

iter_event_stacktraces() (used by handle_in_app) and SENSITIVE_DATA_SUBSTITUTE (used by the data-collection filtering and several integrations) are still used, so they stay.

On master, EventScrubber still uses both helpers, so this only applies to major/3.0. iter_event_frames could be imported from sentry_sdk.utils, but it isn't documented anywhere, and major/3.0 is already a breaking release.

Issues

n/a

via Ivana Kellyer.

--

View Junior Session [Sentry]

Co-Authored-By: Ivana Kellyer <ivana.kellyer@sentry.io>
@sentry-junior
sentry-junior Bot requested a review from a team as a code owner October 29, 2026 11:59
@github-actions

Copy link
Copy Markdown
Contributor

Coverage Results 📊

✅ 57523 passed | ⏭️ 2979 skipped | Total: 60502 | Pass Rate: 95.08% | Execution Time: 157m 51s

All tests are passing successfully.

✅ Patch coverage is 100.00% (no changed executable lines found; target 80%).
Project statement coverage is 90.24% (down 0.09 percentage points from base (3668ba4) to head (6541f1f)).

Files with missing lines (2)
File Coverage % Lines
sentry_sdk/utils.py 92.26% ⚠️ 68 Missing and 34 partials
sentry_sdk/_types.py 88.89% ⚠️ 4 Missing and 2 partials
Coverage diff
@@            Coverage Diff             @@
##        master     #8158       +/-##
==========================================
- Coverage    90.33%    90.24%    -0.09%
==========================================
  Files          203       198        -5
  Tracked lines     26872     21292     -5580
  Branches     10044      7372     -2672
==========================================
- Hits         24272     19213     -5059
+ Misses        2600      2079      -521
+ Partials      1520      1237      -283

Generated by Coverage Action

@sentrivana
sentrivana merged commit 1ac2faf into major/3.0 Oct 29, 2026
153 checks passed
@sentrivana
sentrivana deleted the ivana/remove-event-scrubber-leftovers branch October 29, 2026 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant