Repository navigation
ref: Remove helpers left over from EventScrubber removal - #8158
Merged
Merged
Conversation
Co-Authored-By: Ivana Kellyer <ivana.kellyer@sentry.io>
sentrivana
approved these changes
Oct 29, 2026
Contributor
Coverage Results 📊✅ 57523 passed | ⏭️ 2979 skipped | Total: 60502 | Pass Rate: 95.08% | Execution Time: 157m 51s All tests are passing successfully. ✅ Patch coverage is 100.00% (no changed executable lines found; target 80%). Files with missing lines (2)
Coverage diff@@ Coverage Diff @@
## master #8158 +/-##
==========================================
- Coverage 90.33% 90.24% -0.09%
==========================================
Files 203 198 -5
Tracked lines 26872 21292 -5580
Branches 10044 7372 -2672
==========================================
- Hits 24272 19213 -5059
+ Misses 2600 2079 -521
+ Partials 1520 1237 -283Generated by Coverage Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes two helpers that only
EventScrubberused:iter_event_frames()insentry_sdk/utils.pyAnnotatedValue.substituted_because_contains_sensitive_data()insentry_sdk/_types.py#7772 ("Remove
EventScrubberand theevent_scrubberoption") deletedsentry_sdk/scrubber.py, which held the only call to each of them: frame-vars scrubbing callediter_event_frames(event), and denylisted keys were replaced withAnnotatedValue.substituted_because_contains_sensitive_data(). Both helpers were left behind.Evidence
major/3.0,git grep -wfor each name matches only its definition. There are no callers insentry_sdk,tests,scriptsordocs.iter_event_stacktraces()(used byhandle_in_app) andSENSITIVE_DATA_SUBSTITUTE(used by the data-collection filtering and several integrations) are still used, so they stay.On
master,EventScrubberstill uses both helpers, so this only applies tomajor/3.0.iter_event_framescould be imported fromsentry_sdk.utils, but it isn't documented anywhere, andmajor/3.0is already a breaking release.Issues
n/a
via Ivana Kellyer.
--
View Junior Session [Sentry]