Repository navigation
ref(boto3): Remove unused service_id_hyphenized - #8159
Merged
Merged
Conversation
Co-Authored-By: Ivana Kellyer <ivana.kellyer@sentry.io>
sentrivana
approved these changes
Oct 29, 2026
Contributor
Coverage Results 📊✅ 57523 passed | ⏭️ 2979 skipped | Total: 60502 | Pass Rate: 95.08% | Execution Time: 160m 37s All tests are passing successfully. ✅ Patch coverage is 100.00% (no changed executable lines found; target 80%). Coverage diff@@ Coverage Diff @@
## master #8159 +/-##
==========================================
- Coverage 90.33% 90.21% -0.12%
==========================================
Files 203 198 -5
Tracked lines 26872 21299 -5573
Branches 10044 7378 -2666
==========================================
- Hits 24272 19213 -5059
+ Misses 2600 2086 -514
+ Partials 1520 1238 -282Generated by Coverage Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes
AwsCallContext.service_id_hyphenizedfromsentry_sdk/integrations/boto3/_context.py. It's still computed on every call (service_id.hyphenize()), but onmajor/3.0nothing reads it.It had two readers. One was the
aws.service_idspan tag, which #7261 ("Drop tags auto-set by the SDK") removed. The other was the span name: #7800 ("align span names with OTel conventions") switched that toctx.service_id, so the hyphenized value lost its last reader. This removes the slot, the attribute and thehyphenize()call.Evidence
major/3.0,git grep -w service_id_hyphenizedmatches only the three lines in_context.pythat set it up.major/3.0(feat(boto3): Add Lambda extension #8117 SQS, feat(boto3): Add SQS extension #8137 Lambda) don't reference it.On
master,service_id_hyphenizedis still used for the span name and the tag, so this only applies tomajor/3.0.Issues
n/a
via Ivana Kellyer.
--
View Junior Session [Sentry]