Repository navigation
fix(wsgi): Stop overwriting server.address - #8171
Merged
Merged
Conversation
Contributor
Coverage Results 📊✅ 136856 passed | ⏭️ 7456 skipped | Total: 144312 | Pass Rate: 94.83% | Execution Time: 465m 41s 📊 Comparison with Base Branch
➖ Removed Tests (1)View removed tests
All tests are passing successfully. ✅ Patch coverage is 100.00% (no changed executable lines found; target 80%). Files with missing lines (1)
Coverage diff@@ Coverage Diff @@
## master #8171 +/-##
==========================================
- Coverage 90.33% 90.31% -0.02%
==========================================
Files 203 203 —
Tracked lines 26872 26869 -3
Branches 10044 10042 -2
==========================================
- Hits 24272 24265 -7
- Misses 2600 2604 +4
+ Partials 1520 1516 -4Generated by Coverage Action |
alexander-alderman-webb
marked this pull request as ready for review
November 3, 2026 09:15
sentrivana
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Per OTel semantics,
server.addressis the attribute for WSGI'sSERVER_NAME.The attribute per OTel semantics is the network name.
In
sentry-conventionswe letserver.addressbe the hostname and not just the network name.See getsentry/sentry-conventions@dff430a.
This is needed because
server.addressis the value we formerly put inserver_namein event-based telemetry, and that was always the hostname.There is no other OTel attribute with the matching semantics, so I propose we stop overwriting the
server.addressattribute that is shared between logs, metrics and streamed spans instead of adding a new attribute to conventions.This does mean that we drop WSGI's SERVER_NAME entirely
Issues
Closes PY-2731
Reminders
uv run ruff.feat:,fix:,ref:,meta:)