Skip to content

feat(sidekiq): migrate to ActiveJob-first integration - #3134

Open
solnic wants to merge 1 commit into
chore/3119-switch-activejob-integration-to-the-backend-extension-registryfrom
chore/2937-migrate-sentry-sidekiq-to-aj-first-integration
Open

solnic wants to merge 1 commit into
chore/3119-switch-activejob-integration-to-the-backend-extension-registryfrom
chore/2937-migrate-sentry-sidekiq-to-aj-first-integration

Conversation

@solnic

@solnic solnic commented Oct 13, 2026 •

Copy link
Copy Markdown
Collaborator

Introduces separate native Sidekiq and ActiveJob extensions, shared retry/reporting policies, and core producer/consumer instrumentation. The ActiveJob extension inherits Sentry::Rails::ActiveJobExtension, overrides Sidekiq behavior, and shares handoff helpers with the native integration. Standalone Sidekiq keeps its Rails-independent extension.

Routes ActiveJob jobs through Sentry's ActiveJob integration while preserving Sidekiq trace propagation, retry limits, error reporting, delivery metadata, and scope cleanup. Includes queue conformance, early-failure coverage, and separate processes for isolated specs.

Validated locally with the Ruby 3.4 / Sidekiq 8.0 CI rake task: 138 examples, no failures, one pending profiling test.


Closes #3122
Closes #2937

@solnic
solnic added this pull request to stack #3135 October 13, 2026 13:17
cursor[bot]

This comment was marked as resolved.

@solnic
solnic force-pushed the chore/2937-migrate-sentry-sidekiq-to-aj-first-integration branch from 4586b71 to 412cdfc Compare October 13, 2026 13:23
@solnic
solnic marked this pull request as draft October 13, 2026 13:25
cursor[bot]

This comment was marked as resolved.

@solnic
solnic force-pushed the chore/2937-migrate-sentry-sidekiq-to-aj-first-integration branch 2 times, most recently from 906473e to 4f51c1c Compare October 14, 2026 06:13
@solnic
solnic force-pushed the chore/2937-migrate-sentry-sidekiq-to-aj-first-integration branch from 4f51c1c to 185934b Compare October 14, 2026 06:31
@solnic
solnic force-pushed the chore/2937-migrate-sentry-sidekiq-to-aj-first-integration branch 3 times, most recently from 7671f66 to 87c690c Compare October 14, 2026 08:23
@solnic
solnic force-pushed the chore/2937-migrate-sentry-sidekiq-to-aj-first-integration branch 2 times, most recently from 91bbe8e to 5520b91 Compare October 14, 2026 10:34
@solnic
solnic force-pushed the chore/2937-migrate-sentry-sidekiq-to-aj-first-integration branch from 5520b91 to e76091f Compare October 14, 2026 10:56
@solnic
solnic force-pushed the chore/2937-migrate-sentry-sidekiq-to-aj-first-integration branch from e76091f to 6014ce1 Compare October 14, 2026 11:42
@solnic
solnic removed this pull request from stack #3135 October 14, 2026 11:44
@solnic
solnic changed the base branch from chore/3121-queues-module-conformance-improvements to chore/3119-switch-activejob-integration-to-the-backend-extension-registry October 14, 2026 11:44
@solnic
solnic added this pull request to stack #3137 October 14, 2026 11:44
@solnic
solnic marked this pull request as ready for review October 14, 2026 11:49
cursor[bot]

This comment was marked as resolved.

@solnic
solnic marked this pull request as draft October 15, 2026 08:25
@solnic
solnic force-pushed the chore/2937-migrate-sentry-sidekiq-to-aj-first-integration branch 2 times, most recently from 0160c6e to b79f437 Compare October 15, 2026 10:44
@solnic
solnic force-pushed the chore/2937-migrate-sentry-sidekiq-to-aj-first-integration branch from b79f437 to aae2954 Compare October 15, 2026 11:00
@solnic
solnic force-pushed the chore/2937-migrate-sentry-sidekiq-to-aj-first-integration branch from aae2954 to 833d49d Compare October 15, 2026 11:24
@solnic
solnic marked this pull request as ready for review October 15, 2026 12:20
@solnic
solnic force-pushed the chore/2937-migrate-sentry-sidekiq-to-aj-first-integration branch from 84ac741 to 97641bf Compare October 15, 2026 12:45
@solnic
solnic force-pushed the chore/2937-migrate-sentry-sidekiq-to-aj-first-integration branch from 97641bf to 9a3e4f4 Compare October 15, 2026 12:51
@solnic
solnic force-pushed the chore/2937-migrate-sentry-sidekiq-to-aj-first-integration branch from 9a3e4f4 to 2768792 Compare October 15, 2026 13:37

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 2d1682c. Configure here.

Comment thread sentry-sidekiq/lib/sentry/sidekiq/active_job_support/job_extension.rb Outdated
@solnic
solnic marked this pull request as draft October 20, 2026 08:52
@solnic
solnic force-pushed the chore/2937-migrate-sentry-sidekiq-to-aj-first-integration branch from 2d1682c to 29d356b Compare October 20, 2026 12:44
@solnic
solnic marked this pull request as ready for review October 20, 2026 12:48
@solnic
solnic force-pushed the chore/2937-migrate-sentry-sidekiq-to-aj-first-integration branch from 29d356b to f14ea37 Compare October 20, 2026 12:57
@solnic
solnic force-pushed the chore/2937-migrate-sentry-sidekiq-to-aj-first-integration branch 3 times, most recently from 2d0869f to bb45494 Compare October 23, 2026 10:52
Co-Authored-By: Codex <noreply@example.com>
@solnic
solnic force-pushed the chore/2937-migrate-sentry-sidekiq-to-aj-first-integration branch from bb45494 to 04e3b14 Compare October 23, 2026 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sidekiq: extract shared building blocks Migrate sentry-sidekiq to AJ-first integration

1 participant