Repository navigation
fix(preprod): safely refresh size analysis processing state - #130246
Merged
Merged
Conversation
github-actions
Bot
added
the
Scope: Backend
jamieQ
commented
Nov 6, 2026
| metrics.error_code = put.error_code | ||
| metrics.error_message = put.error_message | ||
| metrics.save() | ||
| case PreprodArtifactSizeMetrics.SizeAnalysisState.PROCESSING: |
Member
Author
There was a problem hiding this comment.
IIUC none of our code previously was ending up here since the PutSizeProcessing request appears to have been unused.
Member
Author
|
bugbot review |
jamieQ
marked this pull request as ready for review
November 6, 2026 16:14
NicoHinderling
approved these changes
Nov 6, 2026
jamieQ
added a commit
that referenced
this pull request
Nov 6, 2026
) Sentry-only mitigation related to #130246 (see that for more detail). Alternative implementation to getsentry/launchpad#732. Refs EME-1341
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Size analysis metrics were never marked
PROCESSINGafter launchpad started processing them. If the processing jobs permanently failed (e.g. the pods repeatedly OOM'd), this could result in stranded metrics that were still markedPENDINGand which aren't currently considered by the cleanup cron (it only looks for items in the processing state). Improve this a bit by having launchpad update the metric's state to processing when appropriate. This PR is the sentry-side changes to handle that.Launchpad PR to deploy after this: getsentry/launchpad#732
Refs EME-1341