Repository navigation
Release 0.2.1: restore npm identity, fix package validation, publish via OIDC - #4
Conversation
The 0.2.0 release commit renamed the package to @gitdamnit/stranger-danger, a name that has never existed on npm, so no 0.2.x release was installable from the registry. `npm run verify:package` also hardcoded that same name and therefore failed its packed-artifact check. - restore @gitdamnit/opencode-stranger-danger as the package name and release the fixes as 0.2.1 (v0.2.0 already points at the misnamed commit) - derive the package name from package.json in scripts/verify-package.mjs - switch publish.yml to manual workflow_dispatch + npm Trusted Publishing - correct every documented package reference and record D-0007
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
gitdamnit
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 63ff88461f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "name": "@gitdamnit/stranger-danger", | ||
| "version": "0.2.0", | ||
| "name": "@gitdamnit/opencode-stranger-danger", | ||
| "version": "0.2.1", |
There was a problem hiding this comment.
The package is now version 0.2.1, but src/shared/version.ts still exports "0.2.0" and the help banner in src/cli/args.ts also hardcodes 0.2.0. Consequently, the new release still identifies itself as 0.2.0 in sd version, CLI help, and the plugin's status tool, making it impossible to distinguish the packaging fix through those interfaces. Running the checked-in CLI confirms strangerDanger v0.2.0. Update these runtime strings with the release bump; the package verifier currently accepts any semver-shaped version output and will not catch the mismatch.
Useful? React with 👍 / 👎.
What changed
package.jsonis again@gitdamnit/opencode-stranger-danger(the name public on npm since 0.1.0). The earlier rename to@gitdamnit/stranger-dangerpointed at a package that does not exist, making 0.2.0 uninstallable from the registry.scripts/verify-package.mjshardcoded@gitdamnit/stranger-dangerin its import and directory checks, so it broke the moment the name changed. It now derives the name frompackage.json.v0.2.0already tags the misnamed commit and has a public GitHub release, so a patch release is used instead of rewriting the tag.publish.ymlruns only onworkflow_dispatch, checks out and verifies the release tag, and publishes through npm Trusted Publishing (supersedes Prepare manual npm Trusted Publishing with OIDC #3).D-0007.Verification
npm run typecheck,npm run lint,npm test(322/322),npm run verify:packageall pass locally.npm pack --dry-runyields 96 files with the expecteddist/, rootindex.js,bin, and rule file.prodoc validateandprodoc checkpass.Not published yet
Merging this does not publish anything. npm Trusted Publishing must be configured for this repository and
publish.ymlfirst, then the workflow is dispatched forv0.2.1.