Skip to content

[GHSA-8f6w-7m2h-mfwg] gopay before 1.5.119 disables TLS certificate... #10179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ranjiGT wants to merge 1 commit into
base: ranjiGT/advisory-improvement-10179
Choose a base branch
from
Open

[GHSA-8f6w-7m2h-mfwg] gopay before 1.5.119 disables TLS certificate... #10179

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 30 additions & 9 deletions advisories/unreviewed/2026/10/GHSA-8f6w-7m2h-mfwg/GHSA-8f6w-7m2h-mfwg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,23 +1,40 @@
{
"schema_version": "1.4.0",
"id": "GHSA-8f6w-7m2h-mfwg",
"modified": "2026-10-04T18:30:21Z",
"modified": "2026-10-04T18:30:27Z",
"published": "2026-10-04T18:30:21Z",
"aliases": [
"CVE-2026-105218"
],
"details": "gopay before 1.5.119 disables TLS certificate verification in defaultClient() in pkg/xhttp/client.go, allowing man-in-the-middle attackers to impersonate payment provider APIs. Attackers can present any certificate to read merchant credentials, signatures and transaction data, and modify payment, refund and order query responses.",
"summary": "GoPay xhttp client disables TLS certificate verification by default",
"details": "GoPay versions 1.5.27 through 1.5.118 disable TLS certificate verification by default in the xhttp client.\n\nThe default client configures `http.Transport` with `tls.Config{InsecureSkipVerify: true}`, causing TLS connections made through the default xhttp client to skip server certificate verification.\n\nAs a result, applications relying on the affected default client may fail to authenticate the remote TLS endpoint, potentially allowing a network-positioned attacker to perform a man-in-the-middle attack.\n\nThe insecure default was introduced before the v1.5.27 release. Version 1.5.119 removes the default `InsecureSkipVerify: true` configuration and enables normal TLS certificate verification. Applications that intentionally require a custom TLS configuration can configure it explicitly.",
"severity": [
{
"type": "CVSS_V3",
"score": "CVSS:3.1/AV:N/AC:H/PR:N/UI:N/S:U/C:H/I:H/A:N"
},
{
"type": "CVSS_V4",
"score": "CVSS:4.0/AV:N/AC:H/AT:P/PR:N/UI:N/VC:H/VI:H/VA:N/SC:N/SI:N/SA:N/E:X/CR:X/IR:X/AR:X/MAV:X/MAC:X/MAT:X/MPR:X/MUI:X/MVC:X/MVI:X/MVA:X/MSC:X/MSI:X/MSA:X/S:X/AU:X/R:X/V:X/RE:X/U:X"
"score": "CVSS:4.0/AV:N/AC:H/AT:P/PR:N/UI:N/VC:H/VI:H/VA:N/SC:N/SI:N/SA:N"
}
Comment on lines 12 to +15

@ranjiGT ranjiGT Oct 5, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment 2 — Retain CVSS v3.1

Confirmed. The original advisory contains the following CVSS v3.1 vector:

`CVSS:3.1/AV:N/AC:H/PR:N/UI:N/S:U/C:H/I:H/A:N`

This existing CVSS v3.1 entry should be retained alongside the normalized CVSS v4 vector:

`CVSS:4.0/AV:N/AC:H/AT:P/PR:N/UI:N/VC:H/VI:H/VA:N/SC:N/SI:N/SA:N`

The intent of the change is only to normalize the malformed CVSS v4 vector, not to remove the existing valid CVSS v3.1 severity metadata.

I attempted to apply the suggested change, but GitHub returned `Failed to commit suggested changes`.

],
"affected": [
{
"package": {
"ecosystem": "Go",
"name": "github.com/go-pay/gopay"
},
"ranges": [
{
"type": "ECOSYSTEM",
"events": [
{
"introduced": "1.5.27"
},
{
"fixed": "1.5.119"
}
]
}
]
}
Comment on lines +18 to 36

@ranjiGT ranjiGT Oct 5, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed against the upstream release tags.

v1.5.41 uses the Go module path:

github.com/iGoogle-ink/gopay

Starting with v1.5.42, the module path changes to:

github.com/go-pay/gopay

The upstream go.mod diff between v1.5.41 and v1.5.42 confirms the rename:

-module github.com/iGoogle-ink/gopay
+module github.com/go-pay/gopay

],
"affected": [],
"references": [
{
"type": "ADVISORY",
Expand All @@ -29,10 +46,14 @@
},
{
"type": "WEB",
"url": "https://github.com/go-pay/gopay/commit/f6df04fd4f64a2ad2c303ba063b6502bfdd259fd"
"url": "https://github.com/go-pay/gopay/commit/988e18a0f7e75ce002e96614e8d8a1a354f593f8"
},
{
"type": "WEB",
"url": "https://github.com/go-pay/gopay/commit/f6df04fd4f64a2ad2c303ba063b6502bfdd259fd"
},
{
"type": "PACKAGE",
"url": "https://github.com/go-pay/gopay"
},
{
Expand Down
Loading