Skip to content

Include diagnostics in failed SARIF if they were created before a database was initialised #4223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mbg merged 21 commits into from
Oct 22, 2026
+1,458 −621
Merged

Include diagnostics in failed SARIF if they were created before a database was initialised #4223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
56e0d42
Refactor `writeDiagnosticFile` out of `writeDiagnostic`
mbg Oct 9, 2026
f422d8a
Write diagnostics to temporary location when database isn't ready
mbg Oct 9, 2026
67f2591
Make diagnostics less dependent on global state
mbg Oct 9, 2026
64723df
Use temporary diagnostic dir in `generateFailedSarif`
mbg Oct 9, 2026
581a0e1
Refactor `writeTemporaryDiagnosticFile` out of `add[NoLanguage]Diagno…
mbg Oct 12, 2026
ba569ac
Omit `--sarif-codescanning-config` if the config file doesn't exist
mbg Oct 16, 2026
b963054
Add e2e test
mbg Oct 12, 2026
8357829
Use same sub-path in `getDiagnosticsPath` for no language case
mbg Oct 21, 2026
d7bad7d
Merge remote-tracking branch 'origin/main' into mbg/diagnostics/faile…
mbg Oct 21, 2026
98b8e51
Always check whether config file exists
mbg Oct 21, 2026
4707994
Don't include diagnostics if FF is off
mbg Oct 21, 2026
67cd8c1
Rename env var to `DIAGNOSTICS_DIR`
mbg Oct 21, 2026
a83f6f5
Update skipped `analyze` step comment
mbg Oct 21, 2026
c3f2a34
Clarify comment that explains how the test works
mbg Oct 21, 2026
26f5c5e
Improve logging and error handling in `logTemporaryDiagnostics`
mbg Oct 22, 2026
308d941
Only warn for missing config if `init` was successful
mbg Oct 22, 2026
b79966a
Clean up path functions in `diagnostics.ts` and add some tests
mbg Oct 22, 2026
2d0d1c1
Merge branch 'main' into mbg/diagnostics/failed-sarif
mbg Oct 22, 2026
ac509b6
Merge branch 'main' into mbg/diagnostics/failed-sarif
mbg Oct 22, 2026
87da5f3
Improve wording to address review feedback
mbg Oct 22, 2026
5196bae
Merge remote-tracking branch 'origin/main' into mbg/diagnostics/faile…
mbg Oct 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
143 changes: 143 additions & 0 deletions .github/workflows/__diagnostics-without-db.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion .github/workflows/__submit-sarif-failure.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading