Skip to content

[Copilot Dreaming] Preserve injected Rust fixes and remove redundant guidance #23124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[Copilot Dreaming] Preserve injected Rust fixes and remove redundant guidance #23124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bd79825
[Copilot Dreaming] Remove a redundant Bazel topology description
Copilot Nov 13, 2026
09ef361
[Copilot Dreaming] Remove the repeated Bazel neighbor-copy instruction
Copilot Nov 13, 2026
92197b9
[Copilot Dreaming] Preserve injected Rust fixes in Bazel builds
Copilot Nov 13, 2026
7995ec2
[Copilot Dreaming] Remove the duplicate Unified architecture recap
Copilot Nov 13, 2026
09da864
[Copilot Dreaming] Remove the repeated Unified expected-file prohibition
Copilot Nov 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions .github/skills/bazel/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,6 @@ description: Conventions for editing Bazel files in the github/codeql repository

# Bazel in the codeql repository

A bzlmod module named `ql`, repo name `@codeql` ([`MODULE.bazel`](../../../MODULE.bazel)). It builds standalone, and is
also consumed by an internal module; standalone builds replace that module with a stub.

## Traps

Things that will waste your time or produce a wrong edit here. Read this section even if you skip the rest.
Expand All @@ -26,7 +23,7 @@ Things that will waste your time or produce a wrong edit here. Read this section

## Conventions

* **Copy a neighboring target rather than inventing a shape.** Packaging is not uniform: some packages use the
* Packaging is not uniform: some packages use the
`codeql_*` wrappers, others still use `pkg_files` directly. Copy the closest *working* neighbor, and prefer the
wrapper for new code.
* **Pin anything fetched over the network** with `sha256` or `integrity`. Bazel only *warns* on an unpinned download, so
Expand Down
2 changes: 2 additions & 0 deletions rust/ast-generator/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,5 @@ bazel run //rust/ast-generator:inject-sources
which will create the missing sources. Be aware that bazel will still use the source taken
directly from `rust-analyzer`, not the one in your working copy. Those should not need to be
update often though.

To retain changes to injected sources in Bazel builds, update `rust/ast-generator/patches/rust-analyzer.patch`.
6 changes: 1 addition & 5 deletions unified/AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,5 @@
# Agent instructions

This is a CodeQL extractor that maps a language's parse tree onto a shared AST
using the `yeast` desugaring engine. Swift, the only language so far, is parsed
by Apple's swift-syntax rather than by tree-sitter.

## Building
- To build the extractor, run `scripts/create-extractor-pack.sh`

Expand Down Expand Up @@ -42,6 +38,6 @@ by Apple's swift-syntax rather than by tree-sitter.

- To run all CodeQL tests, run `codeql test run --search-path extractor-pack ql/test`

- Do not edit `.expected` files manually. To update the expected output, pass `--learn` to the `codeql test run` command.
- To update the expected output, pass `--learn` to the `codeql test run` command.

- To run a specific test, pass the specific directory to the `codeql test run` command instead of `ql/test`.
Loading