Repository navigation
Bump Rust toolchains #23136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Rust toolchains #23136
Changes from all commits
a6359e4
ee799c6
c04c331
162fd74
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -656,7 +656,6 @@ mod tests { | |
| result.include_directories, | ||
| vec![path.clone(), path.join("dir2")] | ||
| ); | ||
| assert!(!result.unresolvable.is_empty()); | ||
| assert_eq!( | ||
| result.unresolvable, | ||
| vec![ | ||
|
|
@@ -817,7 +816,7 @@ mod tests { | |
|
|
||
| // This is empty since `foo.h` is in `system_files` and hence satisfied by | ||
| // `compiler_defaults`. | ||
| assert!(result.include_directories.is_empty()); | ||
| assert_eq!(result.include_directories, Vec::<PathBuf>::new()); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm a bit curious as to why this is the better way to write this assertion. I guess
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, it's because the error that'll get printed on assertion failure is much more informative. |
||
| } | ||
|
|
||
| #[test] | ||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an instance of this rule.
It might look weird to just remove the assert, but the
assert_eq!right below makes it unnecessary and that one will print nicer output if it fails.