Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The documentation matches the Java runtime loader behavior and established setup guidance.
0 open findings
What changed in this PR
Updates bundled-runtime documentation to reflect Java’s platform-specific runtime JAR support.
Changes:
- Documents Java runtime dependency and override options.
- Updates runtime behavior explanation.
- Uses the default Java client constructor.
| File | Description |
|---|---|
docs/setup/bundled-cli.md |
Corrects Java bundled-runtime setup and quick start. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The current CliServerManager.resolveCliLaunch implementation falls back to NativeRuntimeLoader.resolveRuntimeWrapper, and existing loader tests cover extracting the adjacent runtime pair. This only updates the setup guide; it does not change runtime behavior or enable in-process mode.
Fixes #2795.
Validation
The docs task skips Java tests and native artifact downloads. This verifies documentation compilation, not a live CLI launch. No dependency manifests, generated sources, or other documentation files changed.