Skip to content

Add pr triage skill based on the one in github/explore - #3767

Open
ahpook wants to merge 1 commit into
mainfrom
ahpook/add-triage-skill
Open

ahpook wants to merge 1 commit into
mainfrom
ahpook/add-triage-skill

Conversation

@ahpook

@ahpook ahpook commented Nov 13, 2026

Copy link
Copy Markdown
Contributor
  • Have you followed the contributing guidelines?
  • Have you explained what your changes do, and why they add value to the Guides?

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

Adds a PR triage skill, based on the one for github/explore , to help maintainers work through the PR backlog


@ahpook
ahpook requested a review from a team as a code owner November 13, 2026 21:40
Copilot AI dynamic review requested due to automatic review settings November 13, 2026 21:40

Before each closure, reread the live state, head SHA, recent commits, comments, reviews, labels, and holds. Recompute the decision if anything changed after inspection; do not close on a stale snapshot. If new activity is ambiguous, leave it for review.

Use `gh pr close <number> -R github/opensource.guide` with a brief, welcoming closure comment explaining the specific unfinished work and the last substantive update date. Invite a completed follow-up or reopening when work resumes. Do not call the contribution "naive", speculate about intent, or imply that the contributor is unwelcome. Do not delete the branch.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The triage procedure still has two active documentation issues: its prescribed close command omits the required explanatory comment, and its listing command may omit pull requests and the review data needed for complete triage.

2 open issues
What changed in this PR

Adds a repository-specific PR triage skill for evaluating contributions, translations, CI status, and stale translation pull requests in github/opensource.guide.

Changes:

  • Defines evidence-based review guidance using repository contribution, translation, content, style, and persona documentation.
  • Documents PR inspection, CI reporting, approval safeguards, and contributor communication.
  • Adds a guarded 60-day cleanup workflow for clearly incomplete translation PRs.
File Description
.github/​skills/​pr-triage/​SKILL.md Introduces the complete repository-specific pull request triage workflow, including translation assessment, CI guidance, reporting requirements, and stale cleanup procedures.

Review effort: Lite (dynamic)


## Inspection workflow

1. Use `gh pr list -R github/opensource.guide --state open` with sufficient pagination to cover the queue. Collect author, body, labels, draft state, base branch, head SHA, changed files, reviews, comments, and `statusCheckRollup`. Do not change branches or disturb local changes.

Before each closure, reread the live state, head SHA, recent commits, comments, reviews, labels, and holds. Recompute the decision if anything changed after inspection; do not close on a stale snapshot. If new activity is ambiguous, leave it for review.

Use `gh pr close <number> -R github/opensource.guide` with a brief, welcoming closure comment explaining the specific unfinished work and the last substantive update date. Invite a completed follow-up or reopening when work resumes. Do not call the contribution "naive", speculate about intent, or imply that the contributor is unwelcome. Do not delete the branch.

@tomthorogood tomthorogood left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me. I like the explicit details pertaining to translations and long-running work. Thanks for putting this together.


## Goal and sources

Help maintain the Open Source Guides with evidence-based recommendations and a welcoming contributor experience. Prefer human review whenever approval or closure is borderline. Do not equate unfamiliar language, small changes, failing CI, or age alone with a low-quality contribution.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

♥️


Recognize Dependabot by its actual bot identity (`dependabot[bot]`, sometimes displayed as `app/dependabot`), not a similar human login. Treat routine dependency updates and verified repository-owned automation as normal maintenance, not external promotional submissions.

Recommend ✔️ for a routine, in-scope bot change only when its current diff is appropriate and applicable checks pass. Major upgrades, unexpected files, changed permissions, failing or missing checks, or uncertain automation provenance require 🔍. A `github-` prefix alone does not establish trust. Bot status never authorizes approval, merge, or CI execution.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

♥️

- `_articles/<locale>/` should contain translations of the current guides, preserving front-matter field names and functional metadata, Liquid expressions, HTML structure, code examples, links, and anchors.
- Follow the documented removal of the `untranslated` field when content is translated. Removing a marker without translating the content is not completion.
- The locale's `index.html` should follow the root index with the documented `lang` and `permalink` changes; other front-matter values should remain unchanged.
- Look for missing guides or strings, copied English presented as finished translation, placeholder text, mismatched language codes, malformed front matter, broken internal links, and changes to shared templates that merely hide incomplete content.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

♥️

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants