Repository navigation
fix(app): offer channel menu actions only where they can succeed - #525
Merged
Merged
Conversation
Fork appeared on every row and failed on teammates' and cloud compute channels. Rows now carry a fork capability (this host's own, non-compute channels), and archive, delete and compute also require the channel to be this person's channel on this host, matching the host's owner-only ops. The menu hides unavailable Rename, Fork, Info, Leave, Archive, Unarchive, Delete and Rebuild items instead of showing them disabled, and does not open on a row with nothing to offer. Fixes #504 Why: apps/app/src/app.tsx#function row | each capability mirrors a host-side refusal (gateway owned ops, catalog.owns, compute fork); keep them in step when the host's rules change Why: packages/ui/src/components/session-item/session-item-actions.tsx#function RowMenu | an action this row can't perform is hidden, never shown disabled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #504.
The channel context menu now decides each action per row and hides the ones the host would refuse, instead of showing them (or showing them disabled).
forkcapability: the channel runs on this host, the person is its owner, and it isn't a cloud compute channel. This mirrors the host's refusals ingateway.ts(ownedops,catalog.owns, peer fork) andmanage.tsfork.onLeave. It's now hidden.The host still enforces every rule; this only stops the menu from offering actions that can't succeed.
Built in Ace
No — Claude Code subagent outside Ace, run by the lead during a batch of fixes.