Repository navigation
fix: enable clipboard image export, release a paste when its window closes, and skip ordered-out windows in window_appears - #125
Merged
Conversation
…loses, and skip ordered-out windows in window_appears
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the #96, #99 and #89 failures from the full live check against the installed 0.13.1.
#96:
save_pathrefused (CLIPBOARD_WRITE_FAILED/ not supported).peekaboo-clipboard-image-export.patchaddedclipboardImageExport, but not to Peekaboo'sremoteDefaultAllowlist. The embedded host intersects its allowed operations with the embedded allowlist built from that list, so it dropped the export. New patchpeekaboo-clipboard-image-export-allowlist.patchadds it.src/build.tsnow fails the build if any operation inruntime.swift'sallowedOperationswould be dropped. The export was the only one.#99 and the stuck clipboard. The harness pasted an image into an
.rtfTextEdit document. TextEdit opened its "Convert to RTFD?" sheet, the paste never landed, and the paste reservation then refused every clipboard write until TextEdit quits. That broke the harness's own clipboard writes and its restore. New patchpeekaboo-paste-window-release.patchalso releases the reservation when the receiver window is gone, or its number now belongs to another process. The harness now pastes into an.rtfdfixture.#89.
desktop_key. Background keys come backcompleted, andexpectleaves those alone, as documented. It now usesdesktop_system_key f19.com.apple.campo). It keeps its panel listed while ordered out (off screen, on the current Space), andwindow_appearscounted that as already open.window_appearsnow skips a window that is off screen on its display's current Space, unless its app is hidden. The harness picks whichever Spotlight host is running, and sends Escape only after Spotlight was seen open.Verified
npm test(75 pass) andnpm run check.ClipboardPasteTransactionGateTests: 19 pass, including the new window-release test.PeekabooEmbeddedBridgeRuntimeTests: 12 pass, including the export allowlist assertion.--only 89: 3/3 pass.