Repository navigation
fix: Finder live checks, select-all receipts, Finder focus, and Finder renames that never happen - #126
Merged
Conversation
…lean table reads, select-all receipts, Finder focus, and refuse Finder renames that never happen
iamnbutler
force-pushed
the
fix/finder-live-checks
branch
from
October 17, 2026 14:57
ce84ffd to
dbb2027
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the Finder cluster and the #77 key failures from the 0.13.1 live run (14 pass, 8 fail, 17 skip).
Causes and fixes
Product
test/inspect-trim.test.mjs.0in its Name cell.AXAscendingSortDirection.finderRoleLabels).unknownwith "receipt does not match successful projected response outcome".cmd,char:61, andpeekaboo-layout-keys.patchresolveschar:keys withKeyboardLayoutTranslator.current(), which is nil off the main thread.isSelectAllShortcutwas false there. The contract lacked the AX-value select-all rule that the host (on main) had used.peekaboo-layout-shortcuts.patchclassifies paste and select-all chords without a layout.AXFocusedUIElement, plus window ownership) was off for any truncated tree, and Finder always hits the 200-element budget.peekaboo-focus-budget.patchallows the tie-break for budget cuts (depth, count, children) but not for a deadline, an incomplete read or the app-scoped fallback.completedwithout renaming.desktop_set_cell,desktop_typeanddesktop_set_valuenow refuse a Finder file-list name field before input, withCELL_NOT_EDITABLEand a hint (shellmv, or the foreground Finder route).DESKTOP_ACTION_FAILED. The host's at-dispatch focus failure is indeterminate, and the client only handled undispatched failures. Every mid-sequence stop is nowKEY_SEQUENCE_STOPPED, and the message says when the stopping key may have been sent.Harness (
scripts/live-check.mjs)tableOfreadresult.data.table, but columns and rows are top-level.finderTablepicked the sidebar outline.brief()crashed onJSON.stringify(undefined). This was the "reading 'length'" error in feat: paste files into a Finder folder with desktop_insert, confirmed by their names appearing there (#3) #114, feat: paste an image or files into a native text area with desktop_insert, or leave the clipboard replaced on request #99 and feat: save the clipboard image's original bytes with desktop_clipboard_read save_path #96.Verification
npm test: 77 pass.npm run check: clean.npm run build:nativesucceeds with both new patches.ObservedFocusCorroborationTests|HotkeySelectionPolicyTests|HotkeyServiceTargetingTests, 89 pass. CorePeekabooBridgeOperationSemanticPlanTests|HotkeySelectAllReceiptTests|PeekabooBridgeClipboardGuardedHotkeyTests, 74 pass.Known, not fixed here
unknownevery time, with "Cursor restoration: The physical cursor restoration was dispatched but could not be verified". It happened 4 of 4 times on a fixture window. The selection itself is right in my runs. The harness run once selected only the first row. This looks like a bug in modifier-click cursor restoration and needs its own issue.