Repository navigation
docs: attach orphaned javadoc to resolveToolInstance in ComponentRegistry - #1625
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Hi @zh-hanlabs, thank you for your contribution and We appreciate you taking the time to submit this pull request. Since this is your first contribution, could you please complete the Google CLA so we can proceed with the review process? |
d4ad0ff to
6592e8b
Compare
|
Hi @hemasekhar-p, thanks! I've signed the CLA and the |
6592e8b to
09a1496
Compare
|
@zh-hanlabs, thanks for quick update and Our team is currently reviewing your changes and we will reach out if we need any further information. Thank you. |
Please ensure you have read the contribution guide before creating a pull request.
Link to Issue or Description of Change
2. Or, if no issue exists, describe the change:
Problem:
The javadoc describing
resolveToolInstance("Resolves the tool instance based on the tool name from the configuration") is orphaned: it sits directly above theresolveToolsetInstancejavadoc block, leavingresolveToolInstance(String)undocumented.Solution:
Move the orphaned javadoc block down so it is attached to
resolveToolInstance. Comment-only move; no wording or code changes.Testing Plan
Small documentation-only fix (no tests required per the template guidance). Verified the
@param name/@returntext matches the method signature; no behavioral change.Unit Tests:
Manual End-to-End (E2E) Tests:
N/A — comment-only change.
Checklist
Additional context
Contributor CLA is signed / being signed so the CLA check can pass.