Repository navigation
fix: Use BundleURL in verifyartifact example and deprecate Bundle - #4681
Merged
gmlewis merged 1 commit intoOct 28, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4681 +/- ##
=======================================
Coverage 98.63% 98.63%
=======================================
Files 201 201
Lines 18951 18951
=======================================
Hits 18693 18693
Misses 258 258 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
gmlewis
approved these changes
Oct 28, 2026
gmlewis
left a comment
Collaborator
There was a problem hiding this comment.
Thank you, @JamBalaya56562!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
Collaborator
|
Thank you, @Not-Dhananjay-Mishra! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #4077.
Closes: #4550
This takes over #4550 by @keeltrace, which has been blocked on the Google CLA since 2026-10-01 (one of its commits has an author who hasn't signed it). Thank you, @keeltrace, for the original work!
Attestation.BundleURLwas added by #4647 in the meantime, so this PR only contains the parts of #4550 that are not inmasteryet:Attestation.Bundleas deprecated, since GitHub REST API version 2026-03-10 removes thebundleproperty from attestation list responses.verifyartifactexample fetch the bundle frombundle_url, falling back to the embeddedbundle. github.com already returns"bundle": null, even with API version 2022-11-28, so the example inmasterpanics with a nil pointer dereference.Changes from #4550:
bundle_urlis snappy-compressed (Content-Type: application/x-snappy), so the example decompresses it withgithub.com/golang/snappybefore unmarshaling it, asgh attestationdoes. Unmarshaling the downloaded bytes directly, as feat: Support attestation bundle URLs #4550 did, fails withinvalid character '\xbc' looking for beginning of value.With this change, running the example with the digest from its usage text (
2ce2e480…) printsVerification successful!.