Repository navigation
query: allow custom delimiter for nested structs - #191
Open
AdamMagued wants to merge 1 commit into
Open
AdamMagued wants to merge 1 commit into
AdamMagued wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Support specifying a custom delimiter for nested struct scoping via
the "del" struct tag or the "dot" option. By default, nested structs
are scoped with brackets ("user[name]=..."). When "del" is set on a
struct field (or "dot" option is provided), child fields use the
specified delimiter for scoping (e.g. "user.name=...").
Fixes google#79
AdamMagued
force-pushed
the
nested-struct-delimiter
branch
from
October 4, 2026 22:44
7bda1d9 to
a3cbb40
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently, nested struct fields are scoped strictly using bracket notation (
user[name]=acme&user[addr][postcode]=1234). While slices support custom delimiters via thedeltag and named options (comma,space), nested struct scoping did not allow configuring a custom separator such as dot notation (user.name=acme&user.addr.postcode=1234).This change adds support for configuring the delimiter used for scoping nested struct fields:
deltag (e.g.del:".",del:"/") on a nested struct field uses that delimiter for scoping child fields.dotoption in theurltag (e.g.url:"user,dot") sets the delimiter to..scope[name]) remains unchanged.Root Cause Analysis
In
query/encode.go,reflectValuehardcoded bracket-based scoping whenscope != "":There was no mechanism to customize the separator for struct fields, unlike slices which inspect
sf.Tag.Get("del")and tag options.Verification Results
del:"."struct tag.url:",dot"option.del:"/").user.name,user.addr.postcode,user.addr.city).go test -v -cover ./...->coverage: 100.0% of statements.go vet ./...andgofmtrun cleanly with zero warnings.Fixes #79