Repository navigation
fix: read triage metrics from metadata paths - #6288
Open
darshpatel1052 wants to merge 1 commit into
Open
darshpatel1052 wants to merge 1 commit into
darshpatel1052 wants to merge 1 commit into
Conversation
Collaborator
|
Please read our contributing guide before opening pull requests |
Collaborator
|
Whoops apologies, this is assigned to you! (That's what I get for reading my notifications backwards 🙃) |
Author
Haha, totally understandable! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR title: fix: read triage metrics from metadata paths
Overview
The triage page still requests CVE conversion metrics from their old locations, so it cannot display metrics stored under
metadata/. Update the NVD and CVE5 metrics paths for both test and production buckets.Closes #6211
Details
metadata/nvd/metrics/<CVE-ID>.metrics.json.metadata/cve5/metrics/<CVE-ID>.metrics.json.No breaking changes or new dependencies.
AI assistance: OpenAI Codex assisted with implementation, tests, verification, and this description. The exact model variant and reasoning effort are not available in this session.
Testing
Run from
go/unless noted otherwise:go test ./internal/gcs -run TestTriageStore_GetFile_GCS -count=1 -vfailed on the four metrics sources because they requested the old object paths; all six non-metrics sources passed.go test ./internal/gcs ./internal/website -count=1passed, including all 20 new storage read cases and the existing triage HTTP endpoint tests.go run github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.14.0 run ./internal/gcspassed with zero issues.go build -o /tmp/osv-6211-website ./cmd/websitepassed.git diff --checkpassed.Storage reads were verified using a local HTTP test server and the real GCS client. Live test/production bucket access and the full monorepo test suite were not exercised.