Repository navigation
fix(importer): add lookback window and pre-fetch check for REST imports - #6310
Draft
another-rex wants to merge 2 commits into
Draft
another-rex wants to merge 2 commits into
another-rex wants to merge 2 commits into
Conversation
another-rex
force-pushed
the
fix-rest-import-lookback
branch
from
November 4, 2026 23:09
8b4582b to
db53e09
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Stacked on top of #6306.
Summary
Incremental REST imports (
handleImportREST) previously skipped any index entry withmodified <= LastUpdated. BecauseLastUpdatedadvances tomaxModifiedon each run, an advisory update could be permanently missed by the regular importer whenever:modifiedtimestamp order (e.g., an advisory generated slightly earlier than another entry that already advancedLastUpdated), orall.json) already listed the newmodifiedtimestamp on runN, advancingLastUpdated, while the individual<id>.jsonendpoint briefly served the previous version during CDN/storage propagation.Changes
12hlookback window (restImportLookbackWindow) againstLastUpdatedwhen scanning REST index entries inhandleImportREST(while still persisting the trueLastUpdatedwatermark).KnownIDandKnownModifiedfrom the REST index entry ontoWorkItemand checkVulnerabilityStore.GetSourceModifiedat whole-second granularity before openingSourceRecordinprocessUpdate, avoiding redundant HTTP<id>.jsonfetches and Pub/Sub tasks for advisories within the lookback window that are already up to date.agy