Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion googleapiclient/_helpers.py
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ def positional_wrapper(*args, **kwargs):
return positional_decorator
else:
args, _, _, defaults, _, _, _ = inspect.getfullargspec(max_positional_args)
return positional(len(args) - len(defaults))(max_positional_args)
return positional(len(args) - len(defaults or ()))(max_positional_args)


def parse_unique_urlencoded(content):
Expand Down
18 changes: 18 additions & 0 deletions tests/test__helpers.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,24 @@ def function3(pos, kwonly=None):
with self.assertRaises(TypeError):
function3(1, 2)

# Unspecified positional with no default arguments.
@_helpers.positional
def function4(pos1, pos2):
return pos1 + pos2

self.assertEqual(function4(1, 2), 3)
with self.assertRaises(TypeError):
function4(1, 2, 3)

# Unspecified positional with no arguments.
@_helpers.positional
def function5():
return True

self.assertTrue(function5())
with self.assertRaises(TypeError):
function5(1)

@mock.patch("googleapiclient._helpers.logger")
def test_enforcement_warning(self, mock_logger):
_helpers.positional_parameters_enforcement = _helpers.POSITIONAL_WARNING
Expand Down
Loading