Repository navigation
feat(storage): wire logical operation metrics in Retrying and StorageOptions - #14695
Open
nidhiii-27 wants to merge 65 commits into
Open
nidhiii-27 wants to merge 65 commits into
nidhiii-27 wants to merge 65 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request integrates OpenTelemetry metrics into the client-side retry mechanism of Google Cloud Storage. It updates StorageOptions, GrpcStorageOptions, and HttpStorageOptions to expose StorageClientMetrics, and modifies Retrying.DefaultRetrier to record attempts, errors, retries, operations, and duration metrics when metrics are enabled. Additionally, a comprehensive test suite RetryingMetricsTest has been added to verify metric collection across various retry scenarios. There are no review comments, and I have no feedback to provide.
nidhiii-27
force-pushed
the
feat/storage-metrics-context-error-mapping
branch
from
October 20, 2026 11:50
608c46a to
1bf9a9d
Compare
nidhiii-27
force-pushed
the
feat/storage-logical-metrics
branch
from
October 20, 2026 12:11
b385679 to
0a3696b
Compare
cpriti-os
requested changes
Oct 20, 2026
nidhiii-27
added a commit
that referenced
this pull request
Oct 20, 2026
…options - Narrow PR #14695 to core Retrying chokepoint and options wiring - Remove per-run StorageMetricsContext binding from DefaultRetrierWithAlg to avoid elapsed time drift across runs - Add createMetricsContext helper on StorageOptions - Revert veneer operation wiring and server address attributes to separate stacked PR - Update unit tests in RetryingMetricsTest [Generated-by: AI]
nidhiii-27
marked this pull request as ready for review
October 22, 2026 05:02
…nfiguration - Add configuration options to StorageOptions, GrpcStorageOptions, and HttpStorageOptions (enableOtelMetrics, enableOtelDebugMetrics, meterProvider, metricInterval). - Add development gate checking system properties and environment variables in StorageMetricsConfig. - Implement package-private instrument registry in StorageClientMetrics. - Update OpenTelemetryBootstrappingUtils to register client views with custom histogram boundaries and create client meter provider. - Add comprehensive unit tests in StorageOptionsTest, StorageClientMetricsTest, and OpenTelemetryBootstrappingUtilsTest.
Apply spotify fmt-maven-plugin formatting to StorageMetricsConfig, StorageClientMetrics, StorageOptionsTest, and StorageClientMetricsTest. [Generated-by: AI]
Use simple class name Duration instead of fully qualified java.time.Duration in GrpcStorageOptions and OpenTelemetryBootstrappingUtils. [Generated-by: AI]
…trappingUtils Apply spotify fmt-maven-plugin formatting to OpenTelemetryBootstrappingUtils. [Generated-by: AI]
…nd views [Generated-by: AI]
… metrics Refactor addClientHistogramView in OpenTelemetryBootstrappingUtils to remove unit selector and custom view description, preserving instrument default descriptions. Remove deferred Phase 2 connection metrics (dnsLookupDuration, tcpConnectDuration, tlsHandshakeDuration) from StorageClientMetrics, CLIENT_LATENCY_HISTOGRAMS, and StorageClientMetricsTest. Ensure clean Duration imports. [Generated-by: AI]
…rProvider Default api parameter to "grpc" instead of "storage" in createClientMeterProvider, allow specifying "json" / "http" transport protocols for Cloud Monitoring monitored resource storage.googleapis.com/Client, and add unit test coverage in OpenTelemetryBootstrappingUtilsTest. [Generated-by: AI]
Update createClientMeterProvider to use prefix custom.googleapis.com with default monitored resource mapping. Add KEY_URL_TEMPLATE attribute key constant in StorageClientMetrics. [Generated-by: AI]
…for default monitored resource
…geClientMetricsTest [Generated-by: AI]
…m boundary helpers
…d status overrides
…ring for unused transport [Generated-by: AI]
Dhriti07
requested changes
Oct 26, 2026
[Generated-by: AI]
…pper [Generated-by: AI]
…torage-metrics-context [Generated-by: AI]
…-metrics [Generated-by: AI]
… helpers out of StorageOptions [Generated-by: AI]
… tests - Walk the class hierarchy in isAuthException to support anonymous and custom subclasses, and remove redundant simpleName check. - Extract mapSpecificClientCause and mapKnownCause helpers and check specific client causes on HttpResponseException. - Guard against null StatusCode on ApiException. - Restrict single-use HTTP mapping status constants to private visibility, use Ascii.toLowerCase, add boolean parameter comments, and move private constructor to bottom of class. - Split multi-behavior tests in StorageErrorTypeMapperTest, deduplicate test exception classes and CRC32C fixtures, and import SigningException. [Generated-by: AI]
…vements [Generated-by: AI]
- Consolidate CONNECTION_REFUSED, CONNECTION_RESET, and CONNECTIVITY into CONNECTION_ERROR. - Keep DEADLINE_EXCEEDED for server/RPC status codes and HTTP 408/504, reserving TIMEOUT for client timeouts. - Map HTTP 409 to ABORTED. - Include IOException in hasSpecificClientCause so wrapped IOExceptions map to CONNECTION_ERROR. - Match server-side CRC32C and MD5 checksum mismatch messages in isChecksumMismatch. [Generated-by: AI]
Explicitly declare com.google.api:gax-httpjson in java-storage/google-cloud-storage/pom.xml to satisfy Maven dependency:analyze. [Generated-by: AI]
cpriti-os
approved these changes
Oct 31, 2026
cpriti-os
left a comment
cpriti-os
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks for addressing all the review comments!
[Generated-by: AI]
- Check status.getCause() and server checksum mismatch descriptions on INVALID_ARGUMENT and DATA_LOSS in mapGrpcStatus - Simplify StorageException cause handling in mapThrowable by calling mapKnownCause directly - Restrict (crc32c || md5) && match server checksum error pattern to HTTP 400 and gRPC INVALID_ARGUMENT / DATA_LOSS - Add unit tests for mapGrpcStatus causes/descriptions and negative 404/412 checksum message cases [Generated-by: AI]
…ic-libraries-bom [Generated-by: AI]
… entry points [Generated-by: AI]
- Move self-causation check to the bottom of the while loop in extractRpcStatusCode and extractHttpStatusCode so top-level self-causing exceptions are inspected first - Add defensive null checks on getStatus() and getCode() for StatusRuntimeException and StatusException in extractRpcStatusCode - Add unit tests for top-level self-causing exceptions and null status on gRPC status exceptions [Generated-by: AI]
…n StorageErrorTypeMapper - Reword class Javadoc to remove HLD acronym. - Delegate StatusRuntimeException and StatusException directly to mapGrpcStatus. - Cap cause-chain traversal depth (MAX_CAUSE_DEPTH = 20) across mapGrpcStatus and mapThrowable to guard against multi-node cause cycles (A -> B -> A). [Generated-by: AI]
…or-mapping' into feat/storage-metrics-context
[Generated-by: AI]
[Generated-by: AI]
…se.status_code [Generated-by: AI]
…e branch [Generated-by: AI]
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wires client-level metrics lifecycle and retrier operation metrics into StorageOptions and Retrying.
StorageClientMetricsprovider and lifecycle management inStorageOptions.Retryingto record operation attempts, durations, and status attributes.StorageOptionsTest,StorageClientMetricsTest,RetryingMetricsTest).Stacked on #14728.