Repository navigation
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request explicitly defines missing plugin versions and group IDs across several Maven POM files, including flatten-maven-plugin, exec-maven-plugin, maven-checkstyle-plugin, maven-resources-plugin, and fmt-maven-plugin. These changes improve build reproducibility and stability. I have no additional feedback to provide.
|
Do we have other unpinned Maven plugin versions? My AI reviews flags two possible cases:
|
| @@ -102,6 +102,7 @@ | |||
| <plugin> | |||
| <groupId>org.apache.maven.plugins</groupId> | |||
| <artifactId>maven-checkstyle-plugin</artifactId> | |||
| <version>3.6.0</version> | |||
There was a problem hiding this comment.
Not directly related to this PR, but if we change gax-bom to reference java-shared-config in this repo, instead of pin java-shared-config version, I think we can get the version automatically.
There was a problem hiding this comment.
Yeah good point, I'll send a follow up PR for this!
| <artifactId>maven-resources-plugin</artifactId> | ||
| <version>3.3.1</version> |
There was a problem hiding this comment.
I think this pom eventually inherit from java-shared-config, do we need the version here?
There was a problem hiding this comment.
You're right, thanks. I removed the inline pin in a376c5d. The effective version is still 3.3.1.
… pin - Pin maven-assembly-plugin 3.7.1 in google-cloud-firestore. Maven 3.10 warns about the missing version; Maven 3.9 resolves 3.7.1 today. - Pin maven-shade-plugin 3.6.1 in the profile-gated storage-shared-benchmarking module. - Remove the maven-resources-plugin pin from google-cloud-spanner-executor. The module inherits 3.3.1 from java-shared-config pluginManagement.
Good catch, thanks! Both were real, and both are pinned in a376c5d. |
hj690
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Summary
Pin unpinned Maven build plugins across the monorepo to versions available in Airlock (b/568717591).
maven-metadata.xmland resolves newly published Central releases during the Airlock audit.flatten-maven-plugin(1.8.0),exec-maven-plugin(3.5.0), andfmt-maven-plugin(2.25) in standalone and root module POMs.maven-checkstyle-plugin(3.6.0) andmaven-resources-plugin(3.3.1) togoogle-cloud-shared-config<pluginManagement>. Pinmaven-checkstyle-pluginingax-bom, which uses a released parent.maven-assembly-plugin(3.7.1) ingoogle-cloud-firestoreandmaven-shade-plugin(3.6.1) instorage-shared-benchmarking.