Skip to content

feat(storage): support DirectPath over Interconnect in Cloud Monitoring and register channel_creation_latency view - #15025

Open
nidhiii-27 wants to merge 5 commits into
mainfrom
feat/storage-dp-interconnect-channel-metrics
Open

nidhiii-27 wants to merge 5 commits into
mainfrom
feat/storage-dp-interconnect-channel-metrics

Conversation

@nidhiii-27

@nidhiii-27 nidhiii-27 commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Adds Cloud Monitoring endpoint support for DirectPath over Cloud Interconnect (DP over GCI) and registers the channel_creation_latency OpenTelemetry histogram view and recorder in google-cloud-storage.

Key Changes

  • OpenTelemetryBootstrappingUtils:
    • Registers the storage.googleapis.com/internal/client/channel_creation_latency histogram view in createMeterProvider via registerGrpcChannelViews.
    • Adds createChannelCreationLatencyRecorder (configured with explicit seconds-scale latency bucket boundaries advice and transport_type attribute) for recording first-channel creation latency.
    • Exposes the MeterProvider from enableGrpcMetrics via GrpcMetricsChannelConfigurator implements ChannelConfigurator, Supplier<MeterProvider> while preserving the existing method signature.
    • Updates getCloudMonitoringEndpoint to handle google-c2p:/// and google-c2p-experimental:/// targets with query/fragment parameters, storage-direct.googleapis.com, storage-preprod-direct.sandbox.googleapis.com, storage-direct.<universeDomain>, and IPv6 literals, with defensive null/empty handling.
  • OpenTelemetryBootstrappingUtilsTest:
    • Adds unit tests for DirectPath over Interconnect Cloud Monitoring endpoint mapping, registerGrpcChannelViews seconds-scale bucket boundaries, createChannelCreationLatencyRecorder, and GrpcMetricsChannelConfigurator.

@nidhiii-27 nidhiii-27 added the ai-generated Pull Request generated by AI label Nov 16, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces tracking for gRPC channel creation latency metrics and refactors endpoint parsing in OpenTelemetryBootstrappingUtils to be more robust, particularly for C2P and DirectPath interconnect hosts. It also adds corresponding unit tests to validate these changes. The review feedback points out a redundant check in the stream filter of getCloudMonitoringEndpoint and suggests simplifying it using a method reference on resolvedHost to improve clarity and correctness.

…ng and register channel_creation_latency view

- Register storage.googleapis.com/internal/client/channel_creation_latency histogram view in OpenTelemetryBootstrappingUtils.createMeterProvider.
- Expose MeterProvider from enableGrpcMetrics via GrpcMetricsChannelConfigurator implementing Supplier<MeterProvider> while preserving the existing method signature.
- Update getCloudMonitoringEndpoint to support DirectPath over Cloud Interconnect endpoints (storage-direct.googleapis.com, storage-preprod-direct.sandbox.googleapis.com, storage-direct.<universeDomain>, and google-c2p:/// / google-c2p-experimental:/// targets with query/fragment parameters) with defensive null/empty handling.
- Add unit tests in OpenTelemetryBootstrappingUtilsTest.

[Generated-by: AI]
@nidhiii-27
nidhiii-27 force-pushed the feat/storage-dp-interconnect-channel-metrics branch from a306a43 to 640013f Compare November 18, 2026 06:50
@nidhiii-27 nidhiii-27 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 18, 2026
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 18, 2026
@nidhiii-27
nidhiii-27 marked this pull request as ready for review November 18, 2026 10:20
@nidhiii-27
nidhiii-27 requested review from a team as code owners November 18, 2026 10:20

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-generated Pull Request generated by AI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants