Repository navigation
feat(storage): support DirectPath over Interconnect in Cloud Monitoring and register channel_creation_latency view - #15025
Open
nidhiii-27 wants to merge 5 commits into
Open
nidhiii-27 wants to merge 5 commits into
nidhiii-27 wants to merge 5 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces tracking for gRPC channel creation latency metrics and refactors endpoint parsing in OpenTelemetryBootstrappingUtils to be more robust, particularly for C2P and DirectPath interconnect hosts. It also adds corresponding unit tests to validate these changes. The review feedback points out a redundant check in the stream filter of getCloudMonitoringEndpoint and suggests simplifying it using a method reference on resolvedHost to improve clarity and correctness.
…ng and register channel_creation_latency view - Register storage.googleapis.com/internal/client/channel_creation_latency histogram view in OpenTelemetryBootstrappingUtils.createMeterProvider. - Expose MeterProvider from enableGrpcMetrics via GrpcMetricsChannelConfigurator implementing Supplier<MeterProvider> while preserving the existing method signature. - Update getCloudMonitoringEndpoint to support DirectPath over Cloud Interconnect endpoints (storage-direct.googleapis.com, storage-preprod-direct.sandbox.googleapis.com, storage-direct.<universeDomain>, and google-c2p:/// / google-c2p-experimental:/// targets with query/fragment parameters) with defensive null/empty handling. - Add unit tests in OpenTelemetryBootstrappingUtilsTest. [Generated-by: AI]
[Generated-by: AI]
[Generated-by: AI]
nidhiii-27
force-pushed
the
feat/storage-dp-interconnect-channel-metrics
branch
from
November 18, 2026 06:50
a306a43 to
640013f
Compare
[Generated-by: AI]
…cy recorder [Generated-by: AI]
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Cloud Monitoring endpoint support for DirectPath over Cloud Interconnect (DP over GCI) and registers the
channel_creation_latencyOpenTelemetry histogram view and recorder ingoogle-cloud-storage.Key Changes
OpenTelemetryBootstrappingUtils:storage.googleapis.com/internal/client/channel_creation_latencyhistogram view increateMeterProviderviaregisterGrpcChannelViews.createChannelCreationLatencyRecorder(configured with explicit seconds-scale latency bucket boundaries advice andtransport_typeattribute) for recording first-channel creation latency.MeterProviderfromenableGrpcMetricsviaGrpcMetricsChannelConfigurator implements ChannelConfigurator, Supplier<MeterProvider>while preserving the existing method signature.getCloudMonitoringEndpointto handlegoogle-c2p:///andgoogle-c2p-experimental:///targets with query/fragment parameters,storage-direct.googleapis.com,storage-preprod-direct.sandbox.googleapis.com,storage-direct.<universeDomain>, and IPv6 literals, with defensive null/empty handling.OpenTelemetryBootstrappingUtilsTest:registerGrpcChannelViewsseconds-scale bucket boundaries,createChannelCreationLatencyRecorder, andGrpcMetricsChannelConfigurator.