Repository navigation
Conversation
…ition.fromPb BigLake Iceberg tables are returned with type METASTORE, which made fromPb throw and broke listTables/getTable. Parse METASTORE as an external table and fall back instead of throwing for unknown types. Fixes googleapis#12159
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for the METASTORE table type (such as BigLake Iceberg tables) in TableDefinition and updates the fromPb method to gracefully handle unknown future table types instead of throwing an exception. Specifically, unknown types with an external data configuration are mapped to ExternalTableDefinition, while others default to StandardTableDefinition. Comprehensive unit tests have been added to verify these behaviors. I have no feedback to provide as the implementation is clean and well-tested.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BigLake Iceberg tables come back as
"type": "METASTORE", andTableDefinition.fromPbthrew on them, breakinglistTables,getTableandDataset.list.Type.METASTORE, parsed asExternalTableDefinition(keepssourceFormat/sourceUris).ExternalTableDefinitionorStandardTableDefinition, keeping the original type.TableDefinitionTest. Fails on main, passes with the fix; full unit suite green.Fixes #12159