Skip to content

Accept Stripe webhook events from any API version #879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KrzysztofPajak wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Accept Stripe webhook events from any API version #879

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 16 additions & 12 deletions src/Plugins/Payments.StripeCheckout/Services/StripeCheckoutService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,25 +39,29 @@ public async Task<string> CreateRedirectUrl(Order order)

public async Task<bool> WebHookProcessPayment(string stripeSignature, string json)
{
Event stripeEvent;
try
{
var stripeEvent = EventUtility.ConstructEvent(json, stripeSignature,
_stripeCheckoutPaymentSettings.WebhookEndpointSecret);
// Handle the event
if (stripeEvent.Type == EventTypes.PaymentIntentSucceeded)
{
var paymentIntent = stripeEvent.Data.Object as PaymentIntent;
await CreatePaymentTransaction(paymentIntent);
return true;
}
//the account's default API version (the one the webhook endpoint sends events in) rarely
//matches the version pinned by Stripe.net - the fields read below are stable across versions,
//so a mismatch must not reject the event
stripeEvent = EventUtility.ConstructEvent(json, stripeSignature,
_stripeCheckoutPaymentSettings.WebhookEndpointSecret, throwOnApiVersionMismatch: false);
}
catch (StripeException e)
{
_logger.LogError(e, "StripeException");
return false;
//rethrown so the webhook answers with an error and Stripe shows the failure and retries
_logger.LogError(e, "Stripe webhook event could not be verified");
throw;
}

return false;
// Handle the event
if (stripeEvent.Type != EventTypes.PaymentIntentSucceeded)
return false;

var paymentIntent = stripeEvent.Data.Object as PaymentIntent;
await CreatePaymentTransaction(paymentIntent);
return true;
}

private async Task CreatePaymentTransaction(PaymentIntent paymentIntent)
Expand Down
Loading