Skip to content

Agent docs: table routing, vocabulary by area, persisted-data checklist - #882

Merged
KrzysztofPajak merged 7 commits into
developfrom
docs/ai-harness-cleanup
Oct 7, 2026
Merged

KrzysztofPajak merged 7 commits into
developfrom
docs/ai-harness-cleanup

Conversation

@KrzysztofPajak

@KrzysztofPajak KrzysztofPajak commented Oct 7, 2026 •

Copy link
Copy Markdown
Member

Type: docs

Issue

Agents working from AGENTS.md and .ai/ were missing part of the context they need:

  • five knowledge files (repository-map, admin-areas, plugin-types, module-types, template-types) existed but were not routed from AGENTS.md, so agents never loaded them;
  • knowledge files were listed under skill routing, and the routing was a long flat bullet list;
  • two paths pointed at locations that no longer exist (ICookiePreference.cs, admin controllers folder);
  • the persisted-data checklist did not cover the traps that keep costing time (migration version gate, UTF-16 resource file, whole-object store settings).

Solution

  • AGENTS.md restructured: one table per kind of file (prompts, workflows, skills, knowledge, glossary, standards, checklists, examples, agents), knowledge separated from skills, the five missing knowledge files routed, operating rules tightened.
  • .ai/glossary/vocabulary.md: the domain vocabulary grouped by area (catalog, sales, customers, platform, extensibility), with the word to write, the word to avoid and the implementing type. Glossary index rewritten as a lookup table.
  • .ai/checklists/persisted-data.md: reorganised around what an installation with existing data goes through, now covering the migration version gate (MigrationManager only runs migrations newer than the installed version), the UTF-16 DefaultLanguage.xml that grep cannot read, whole-object store settings and PascalCase field names. All references updated.
  • Fixed paths: Interfaces/Cms/ICookiePreference.cs, Grand.Web.Admin/Controllers/ (+ Store/Vendor equivalents).

Breaking changes

None. Documentation only.

Testing

  1. Every .ai/*.md path referenced from .ai/, .github/ and AGENTS.md exists.
  2. Every .md file under .ai/ (except READMEs) is routed from AGENTS.md.
  3. No remaining references to the removed data-change.md and renamed-terms.md.

The glossary's term table becomes vocabulary.md, framed as which word
to use and which to avoid, so agents pick the domain name when they
create types, models and resource keys.

AGENTS.md now routes to the five knowledge files it did not list
(repository-map, admin-areas, plugin-types, module-types,
template-types). Two paths that no longer exist are corrected:
ICookiePreference lives under Interfaces/Cms, and admin controllers
live in Grand.Web.Admin/Controllers.
Copilot AI balanced review requested due to automatic review settings October 7, 2026 15:43

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

A shared PreToolUse hook stops Claude Code from committing or pushing
while the checkout is on a protected branch, and from pushing to one
explicitly. Work reaches those branches only through a pull request.
The checklist is reorganised around the question it exists to answer -
what an installation that already holds data goes through on upgrade -
and now carries the traps that kept costing time: the migration version
gate, the UTF-16 DefaultLanguage.xml that grep cannot read, store-scoped
settings replacing the whole object, and PascalCase field names when
checking documents by hand. References are updated.
AGENTS.md routing is now one table per kind of file (prompts, workflows,
skills, knowledge, glossary, standards, checklists, examples, agents),
with knowledge separated from skills and the protected-branch hook named
in the operating rules. The vocabulary page is grouped by domain area,
the glossary index is rewritten as a lookup table, and the persisted
data checklist gets a name that says what it guards.
@KrzysztofPajak KrzysztofPajak changed the title Tidy the agent docs: vocabulary glossary, routing and stale paths Agent docs: table routing, vocabulary by area, persisted-data checklist, branch hook Oct 7, 2026
Read the branch from the hook's cwd, then from any cd <dir> or git -C <dir> in the
command, instead of the project root, so a worktree on a feature branch is judged
by its own branch. Accept global git options before the subcommand, match
refs/heads/ and several refspecs in a push target, and judge each shell segment on
its own so text inside another command no longer trips it.
GitHub branch protection already guards develop and main, so the agent-only hook
is removed with its settings file; the operating rule stays in AGENTS.md. The tag
helper doc comment rewrite is out of scope for this docs change and is reverted.
@KrzysztofPajak KrzysztofPajak changed the title Agent docs: table routing, vocabulary by area, persisted-data checklist, branch hook Agent docs: table routing, vocabulary by area, persisted-data checklist Oct 7, 2026
@KrzysztofPajak
KrzysztofPajak merged commit 7b8eb6f into develop Oct 7, 2026
6 checks passed
@KrzysztofPajak
KrzysztofPajak deleted the docs/ai-harness-cleanup branch October 7, 2026 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants