Repository navigation
docs: document JSON value serialization for Deque - #385
Open
Hugohong258 wants to merge 1 commit into
Open
Hugohong258 wants to merge 1 commit into
Hugohong258 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dequeindexing and iteration fail withJSONDiskbecause queue keys bypassDisk.put()and are later passed toJSONDisk.get(). Add the limitation and the value-only JSON subclass suggested in #291 to the tutorial, with a runnableDequeexample. This documents the workaround without changing serialization or queue behavior.Validation: reproduced the indexing and iteration failures against the current source and executed the exact new example. Nine checks cover the failure, ordinary
push/pull, indexing, iteration, both deque ends, reopening the cache, and default key lookup with the subclass. The Sphinx HTML build passes with warnings treated as errors after installing the optional Django dependency required by the existing API documentation. The full runtime/stress suite was not run.git diff --checkpasses.