Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An empty Index currently compares equal to an empty list or string, while comparisons with None or a same-length nonempty list raise TypeError/AttributeError. Return NotImplemented for non-mappings in both equality methods, allowing Python to try the other operand's reflected comparison.
Fixes #387. Preserve the existing order-sensitive Index/OrderedDict comparisons and order-insensitive general mapping comparisons. This is independent of #378, which addresses missing-key sentinel collisions between mappings.
Validation on Windows:
Found through code inspection and prepared/tested with OpenAI Codex assistance under the account owner's OSS contribution request. No production incident or independent human review is claimed.