Repository navigation
Fix null literals in JSON and Object scalar lists - #211
Merged
Merged
Conversation
bbakerman
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JSON and Object scalar literals such as
[1, null, 2]currently throw an internalAssertException. Preserve null elements by handlingNullValuedirectly in the shared literal parser, including nested lists and lists inside objects. Object fields now use the same null handling instead of a separate special case.Add regression coverage for Object scalar AST parsing and complete GraphQL queries using the JSON scalar. Cover null-only and mixed lists, nested lists, lists inside objects, null object fields, top-level null, and JSON variables.
Validation:
./gradlew clean build: all 1,130 tests passed on Java 25, with none skipped.