[Jo-9m-n1]

Summary:

Fixes failing Mocha integration tests and related API bugs in hacker stats and resume upload authorization.

List of changes:

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Test:

• Use cross-env such that DEBUG and NODE_ENV work on Windows.
• Run tests with test, instead of development so it uses the test database.
• Add cross-env as a devDependency.

Hacker stats:

• Fix GET /api/hacker/status returning 500 due to an undefined age variable when incrementing age counts.
• add reviewer stat buckets expected by tests.
• Fix fieldOfStudy aggregation and guard missing dietaryRestrictions.

Resume upload auth:

• Compare account IDs with String(), instead of String.toString(), so only the account linked to the hacker can upload a resume for that ID.

Test:

• Resume upload test: log in with noTeamHackerAccount0 instead of the hacker fixture without email/passowrd.

Type of change

• Bug fix (non-breaking change which fixes an issue)

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• npm run test-windows: 171 (all) passing (took around 20 mins) on local Mongo test DB

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• My changes generate no new warnings
• Listed change(s) in the Changelog
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• I have made corresponding changes to the documentation
• Any dependent changes have been merged and published in downstream modules

[janekhuong]

thanks for fixing the tests. a few notes:

• update the package-lock.json file with cross-env
• can we drop all the "-windows" scripts and use cross env for all of them?
• add a "--timeout 10000" flag to test script; there are a couple tests timing out bc they take longer than 2 seconds

so the script section would now look like:
"scripts": {
"start": "cross-env DEBUG=hackboard:* NODE_ENV=development nodemon --ignore gcp_creds.json ./bin/www.js",
"deploy": "NODE_ENV=deployment node ./bin/www.js",
"debug": "cross-env DEBUG=hackboard:* NODE_ENV=development nodemon --ignore gcp_creds.json ./bin/www.js",
"test": "cross-env DEBUG=hackboard:* NODE_ENV=test mocha -r dotenv/config --reporter spec "tests/.js" --exit --timeout 10000",
"seed": "cross-env NODE_ENV=development node ./seed/index.js",
"docs": "apidoc -i ./routes -o ./docs/api/",
"format": "prettier --write "/.js"",
"lint": "eslint --fix "**/.js""
}

[krubenok]

Humor an old alum who saw this in GitHub notifications... I know this isn't what's in the model but seeing this in the diff is triggering me. Shouldn't this be modeled as an object?

reviews: [
    {
        reviewerId: "...", // Reference to the reviewer's account
        status: "Accept",
        comments: "Good experience and a thoughtful application."
    }
]