Repository navigation
Throw ToolExecutionStopped from stopped SystemLanguageModel responses - #397
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes a
SystemLanguageModelresponse that a tool execution delegate stops behave like one from the HTTP models. Until now, such a response ended with0forIntandfalseforBool, which looks like the model's answer, and threwGeneratedContentError.typeMismatchfor a structure with required properties. The model now uses the sharedStoppedContentvalues inrespondand in streaming, and throwsLanguageModelSession.ToolExecutionStoppedwith the transcript entries for types that can't be empty. A stream keeps its last snapshot only if that snapshot decodes as the complete type, and the error from a stream carries the usage of its requests, so the session counts them.