Repository navigation
Conversation
sidevesh
marked this pull request as ready for review
October 28, 2026 18:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standalone accessory reads currently hardcode
available = True, so an accessory whoseavailableproperty returnsFalsecan still return stale characteristic values with a success status. Bridged accessories already respect this property.Read
self.accessory.availablefor the standalone accessory as well. An unavailable accessory then uses the existingSERVICE_COMMUNICATION_FAILUREresponse without avalue, and successful reads resume when it becomes available again.This addresses the library behavior underlying home-assistant/core#186542. The review there suggested handling availability in HAP-python: home-assistant/core#186542 (comment)
Regression coverage checks available and unavailable reads for both standalone and bridged accessories, ensures unavailable getters are not called, and verifies recovery.
Validation:
test_start_from_syncalso fails on the unchanged baseline becauseasyncio.SafeChildWatcherwas removed in Python 3.14. The repository CI matrix covers Python 3.9–3.13.git diff --checkpass.Verified with HAP-python 5.0.0 patched in a Home Assistant 2026.10.4 container: after restarting Home Assistant, Apple Home displays the unavailable accessory as “No Response” instead of the stale power state.