Repository navigation
Conversation
kmlyz
force-pushed
the
fix/expose-parse-options
branch
from
November 6, 2026 01:37
d0ab16d to
fbf5cfa
Compare
Contributor
|
Thanks for opening this PR, let me have a look at it soon |
getSolidDatasetWithAcl, getSolidDatasetWithAcr, getSolidDatasetWithAccessDatasets, and WebID profile helpers did not include ParseOptions in their options parameter types, preventing callers from supplying custom RDF parsers for non-Turtle resources. Extend the options types on these dataset-fetching functions with Partial<ParseOptions> and forward parser options to underlying getSolidDataset calls. Fixes inrupt#2529
kmlyz
force-pushed
the
fix/expose-parse-options
branch
from
November 7, 2026 19:12
fbf5cfa to
ef152eb
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #2529.