Repository navigation
Encode IDs in Legacy client request paths - #408
Merged
Merged
Conversation
Route caller-supplied IDs through a helper that percent-encodes the value and rejects empty, "." and ".." so each ID stays a single path segment. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
levindixon
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
The Legacy client puts IDs into request paths without encoding them. An ID containing
/,?or#changes which URL is requested, and.or..are treated as relative path segments.How?
Each ID is now encoded as a single path segment, and an empty,
.or..ID is rejected with an error. Only the hand-written Legacy client changes.Local test run
phpunit couldn't run locally (no Packagist access). A standalone script calling all 13 changed path helpers passes on this branch and fails on master, and
php -lis clean on PHP 8.1.Generated with Claude Code