Repository navigation
fix(modal): use drag distance for sheet dismissal - #31524
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
OS-susmitabhowmik
marked this pull request as ready for review
October 2, 2026 21:18
OS-susmitabhowmik
requested review from
thetaPC
and removed request for
brandyscarney
October 5, 2026 21:46
thetaPC
requested changes
Oct 7, 2026
thetaPC
left a comment
thetaPC
left a comment
Contributor
There was a problem hiding this comment.
Thanks for tracking this down! Fixing progress to use the drag distance is the right call. I left a few line comments, mostly about the early return 0 for sheets with only 0 and 1 breakpoints.
Two other things:
mainhas the same bug since 8.8.0 (#30962), so it ships in 8.8.x and 9.0.x too. Should the progress fix targetmain, with the physics-based part handled whenmainsyncs intonext?- The PR title is 83 characters, and CONTRIBUTING caps commit headers at 50. Maybe
fix(modal): stop sheets dismissing on upward drags?
OS-susmitabhowmik
changed the title
OS-susmitabhowmik
changed the title
Contributor
Author
@thetaPC Thank you for the thorough review! I've applied your suggestions and also created a separate PR to add the progress based fix to target main (#31553). Could you please take another look at this PR as well as the new PR targeting main? |
OS-susmitabhowmik
added a commit
that referenced
this pull request
Oct 9, 2026
Issue number: resolves internal --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> Dragging a sheet modal upwards dismisses it, depending on where the user's pointer is relative to the viewport height rather than how far they dragged. It happens when the pointer is in the bottom half of the viewport, so it's most noticeable on smaller sheet modals where the whole sheet sits in that area. Swiping up should scroll the content, or expand the sheet if it isn't at its largest breakpoint yet. Dragging a sheet upwards no longer dismisses it. How open the sheet is now comes from the drag distance over the sheet's own height, so the breakpoint it snaps to and the position it's drawn at come from the same measurement. Sheets with breakpoints in between snap to the nearest one. A quick downward flick still dismisses, because the drag is projected forward by its velocity before snapping to the nearest breakpoint. A small, slow drag snaps the sheet back instead of closing it. Event progress (`ionDragMove`/`ionDragEnd`) is now normalized to 0 at the lowest breakpoint and 1 at the highest, matching the documented contract. Additionally, the Ionic theme's physics-based gesture is refactored to use the fixed progress calculation. Velocity constants are renamed to describe the gesture direction (`FLICK_DOWN_VELOCITY`, `FLICK_UP_VELOCITY`) rather than the outcome. The redundant velocity check in the 40% dismissal rule is removed, so medium-speed downward drags past the threshold now dismiss instead of snapping back. - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer for more information. --> - [Sheet Modal Test Page](https://ionic-framework-git-rou-13053-fix-modal-sheet-dismissal-ionic1.vercel.app/src/components/modal/test/sheet/) --------- Co-authored-by: ionitron <hi@ionicframework.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves internal
What is the current behavior?
Dragging a sheet modal upwards dismisses it, depending on where the user's pointer is relative to the viewport height rather than how far they dragged. It happens when the pointer is in the bottom half of the viewport, so it's most noticeable on smaller sheet modals where the whole sheet sits in that area. Swiping up should scroll the content, or expand the sheet if it isn't at its largest breakpoint yet.
What is the new behavior?
Dragging a sheet upwards no longer dismisses it. How open the sheet is now comes from the drag distance over the sheet's own height, so the breakpoint it snaps to and the position it's drawn at come from the same measurement. Sheets with breakpoints in between snap to the nearest one.
A quick downward flick still dismisses, because the drag is projected forward by its velocity before snapping to the nearest breakpoint. A small, slow drag snaps the sheet back instead of closing it.
Event progress (
ionDragMove/ionDragEnd) is now normalized to 0 at the lowest breakpoint and 1 at the highest, matching the documented contract.Additionally, the Ionic theme's physics-based gesture is refactored to use the fixed progress calculation. Velocity constants are renamed to describe the gesture direction (
FLICK_DOWN_VELOCITY,FLICK_UP_VELOCITY) rather than the outcome. The redundant velocity check in the 40% dismissal rule is removed, so medium-speed downward drags past the threshold now dismiss instead of snapping back.Does this introduce a breaking change?
Other information