Repository navigation
fix(react-router): reveal pages in one view - #31580
Open
Elements2720 wants to merge 1 commit into
Open
Elements2720 wants to merge 1 commit into
Elements2720 wants to merge 1 commit into
Conversation
|
@Elements2720 is attempting to deploy a commit to the Ionic Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issue #31525 occurs when a single Ionic view swaps different
IonPageelements while retaining the same view ID:This PR:
/*and pushes with bare*.Resolves #31525
Evidence
ion-page-invisibleremaining on the entering page.npx playwright test root-single-view root-splat-sibling --retries=0passed all 7 tests.Merge Danger
Door: Two-way
The change is limited to React Router transition deduplication and its regression test app. It preserves duplicate suppression when the same page element is involved.
Blast Radius: react-router