Skip to content

fix(react-router): reveal pages in one view - #31580

Open
Elements2720 wants to merge 1 commit into
ionic-team:mainfrom
Elements2720:fix/react-router-single-view-reveal
Open

Elements2720 wants to merge 1 commit into
ionic-team:mainfrom
Elements2720:fix/react-router-single-view-reveal

Conversation

@Elements2720

Copy link
Copy Markdown

Summary

Issue #31525 occurs when a single Ionic view swaps different IonPage elements while retaining the same view ID:

StackManager duplicate guard
  view IDs only
    new IonPage is treated as the previous transition
    page remains ion-page-invisible
  view IDs + entering IonPage element
    new page follows the normal transition path
    page is revealed

This PR:

  • Includes the entering page element in duplicate-transition detection.
  • Adds a root-single-view reproduction app.
  • Covers successive root navigations with /* and pushes with bare *.

Resolves #31525

Evidence

  • Before: the focused regression suite failed both scenarios with ion-page-invisible remaining on the entering page.
  • After: npx playwright test root-single-view root-splat-sibling --retries=0 passed all 7 tests.
  • Additional checks: React Router typecheck, ESLint, Prettier, package build, and test-app build passed.

Merge Danger

Door: Two-way

The change is limited to React Router transition deduplication and its regression test app. It preserves duplicate suppression when the same page element is involved.

Blast Radius: react-router

@Elements2720
Elements2720 requested a review from a team as a code owner October 16, 2026 13:07
@Elements2720
Elements2720 requested a review from thetaPC October 16, 2026 13:07
@vercel

vercel Bot commented Oct 16, 2026

Copy link
Copy Markdown

@Elements2720 is attempting to deploy a commit to the Ionic Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added the package: react @ionic/react package label Oct 16, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: react @ionic/react package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: (react-router): page stays ion-page-invisible after root navigations when the outlet holds a single splat view

1 participant