Repository navigation
fix(app): clean up tap-click and focus-visible listeners on unmount - #31587
Open
rudrakshagarwal4200-ai wants to merge 2 commits into
Open
rudrakshagarwal4200-ai wants to merge 2 commits into
rudrakshagarwal4200-ai wants to merge 2 commits into
Conversation
Refactor startTapClick to return a cleanup function and handle undefined doc case.
Add tapClickCleanup to manage tap-click event cleanup.
|
@rudrakshagarwal4200-ai is attempting to deploy a commit to the Ionic Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #30094.
Description of Change
startTapClickattaches globalpointerdown,pointerup,pointercancel, andionGestureCapturedevent listeners directly todocument. When<ion-app>is unmounted and remounted (e.g. in Vue 3 component key changes, Storybook, or test environments), new listeners were added without removing previous listeners. This caused multiple ripple effects to stack on top of each other, making ripples appear unnaturally dark or white.startTapClicknow returns a cleanup callback, automatically clears any previous listener set before re-attaching, and<ion-app>invokes this cleanup indisconnectedCallback.<ion-app>now invokesthis.focusVisible.destroy()ondisconnectedCallback, properly removing document keydown, focusin, focusout, touchstart, and mousedown listeners registered bystartFocusVisible.