Repository navigation
Fix config loading when file extension is explicit - #993
Open
mikegit123git wants to merge 1 commit into
Open
mikegit123git wants to merge 1 commit into
mikegit123git wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #850.
Application.load_config_file()currently strips the extension from the specified filename and loads both.pyand.jsonconfiguration files sharing the same basename.This is unexpected when an explicit filename is provided and may cause unintended Python code execution when loading a JSON configuration.
This PR:
.pyand.jsonextensions, loading only the requested file type.Reproduction
Given:
foo.py
foo.json
{"Foo": {"bar": 11}}Calling
app.load_config_file(py_path)previously producedbar == 11because both files were loaded.After the fix,
bar == 10and onlyfoo.pyis loaded.Testing
Validated locally on Ubuntu 22.04 with Python 3.10:
The local documentation build was blocked during dependency installation. GitHub CI verification is pending.