Repository navigation
fix(event): allocate loop->ios in hloop_init - #900
Merged
Merged
Conversation
hio_get() allocated loop->ios on first use, on whichever thread got there first. TcpClient::createsocket() calls hio_get() on the caller's thread, and EventLoopThread::start() returns before hloop_run() has created the eventfd io, so the two first allocations can race and one io is lost. Allocating the array in hloop_init() leaves only fds >= IO_ARRAY_INIT_SIZE to resize lazily.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hloop_initleavesloop->iosunallocated, so the firsthio_get()allocates it.EventLoopThread::start()returns once the loop is running, beforehloop_run()has created the eventfd io, andWebSocketClient::open()callscreatesocket()->hio_get()on the caller's thread. When those two are the firsthio_get()on the loop, both allocate the array and one io is lost. The queuedstartConnectthen reachesiowatcher_add_eventwithloop->ios.ptr[fd] == NULL:We hit it about once in 360 runs of a test that starts an
EventLoopThreadand immediately connects aWebSocketClient. With the array allocated inhloop_initit did not recur in 1800 runs. fds at or pastIO_ARRAY_INIT_SIZEstill resize lazily.