Repository navigation
Preserve all glTF joint attachments - #3038
Merged
Merged
Conversation
jaime-jmebot
approved these changes
Nov 3, 2026
jaime-jmebot
left a comment
Contributor
There was a problem hiding this comment.
Hi @riccardobl, thanks for submitting this pull request!
Overview
This change resolves an issue in GltfLoader where glTF joint nodes containing multiple attached child spatials would only retain the last attached spatial, discarding any preceding ones.
Technical Discussion
GltfLoader: Converting the singleattachedSpatialfield onJointWrapperinto aList<Spatial>(attachedSpatials) allowsfindChildren()to accumulate all non-joint child spatials attached to a bone. DuringsetupControls(), all attached spatials are iterated over and safely added to the correspondingAttachmentsNodeon theSkinControl.- Test Coverage: The added unit test (
keepsEverySpatialAttachedToTheSameJoint) along withJointAttachments.gltfverifies that multiple attachment nodes on a single joint survive glTF import and remain reachable via scene traversal.
Everything is neatly structured, correct, and well-tested. Great improvement for glTF support!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the gltf loader to support more than one attachment per bone