Repository navigation
fix(init): scaffold apps that the platform pipeline can deploy - #5
Merged
Merged
Conversation
- deploy.yml granted contents: read, but the platform's expand step commits generated Terraform; grant contents: write at workflow level and drop secrets: inherit (no secrets are needed). - app.yaml had no routing:, so the service got no URL or ALB rule. Prompt for host and priority. - kotlin emitted a Maven Dockerfile; use Gradle installDist. - The printed add-repo-to-team command used the wrong API shape. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Merge main into the init scaffolding branch and extend init's next steps with `javabin aws setup` and `javabin secret set` after the first deploy. Pin the rendered app.yaml with a golden test (validated against the platform generator) and assert deploy.yml has workflow_dispatch and no secrets: inherit. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
javabin initscaffolded repos the platform pipeline could not deploy. This fixes what it writes:permissions(id-token: writefor AWS OIDC,contents: writeso the expand step can commit generated Terraform,pull-requests: writefor plan comments),workflow_dispatch:for manual runs, and nosecrets: inherit.routing:with a hostname prompt (default<name>.javazone.no) and a validated ALB rule priority, so a web service gets a URL.installDistDockerfile instead of a Maven build.javabin aws setupfor AWS access, andjavabin secret setonce secrets are declared and deployed.Brought up to date with main (merge, after #6/#7/#8; no conflicts).
Verification
cmd/init_test.go: golden test ofrenderAppYaml, deploy.yml permissions /workflow_dispatch/ nosecrets: inherit.platform/scripts/generate-modules.py: it generates theservice-routing(priority 4242, host header) andecs-servicemodules without errors.gofmt -l .clean,go vet ./...,go test ./...(38 passed),sh scripts/next-version_test.shpass.javabin initwas not run for real (it creates repos in the org).🤖 Generated with Claude Code